Knowledge and Skill contribution fails if the initial#170
Merged
nerdalert merged 1 commit intoinstructlab:mainfrom Sep 14, 2024
Merged
Knowledge and Skill contribution fails if the initial#170nerdalert merged 1 commit intoinstructlab:mainfrom
nerdalert merged 1 commit intoinstructlab:mainfrom
Conversation
taxonomy clone is not present in user github account. UI attempts to create the clone, but the clone can take some time to finish. When UI attempts to get the base sha of the repo's main branch it fails because the repository is empty. Add retry logic to check the bash sha every 5 seconds and make 10 attempts. If clone takes more than 50 seconds it fails. In this specific scenario, when user creates it's first contribution, it can take a bit longer because of the repo cloning. Without any notification, this wait time might look like a no-op to the user. To address this added a spinner with an alter message that notifies user that the submission is in progress. Patch also includes refactoring of duplicate code present across api/skill and api/knowledge. Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Member
Author
|
nerdalert
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taxonomy clone is not present in user github account.
UI attempts to create the clone, but the clone can take some time to finish. When UI attempts to get the base sha of the repo's main branch it fails because the repository is empty.
Add retry logic to check the bash sha every 5 seconds and make 10 attempts. If clone takes more than 50 seconds it fails.
In this specific scenario, when user creates it's first contribution, it can take a bit longer because of the repo cloning. Without any notification, this wait time might look like a no-op to the user. To address this added a spinner with an alter message that notifies user that the submission is in progress.
Patch also includes refactoring of duplicate code present across api/skill and api/knowledge.
Fixes #52