Adding DEV auto-fill functionality for both the knowledge and skills form#169
Merged
vishnoianil merged 12 commits intoinstructlab:mainfrom Sep 19, 2024
Merged
Conversation
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…e it is not inherited. Therefore this will be the only field users will have to fill out. Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…r to auto fill the skills form Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
vishnoianil
suggested changes
Sep 14, 2024
Member
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
@aevo98765 Great! work here, it's really very very helpful and reduces a lot of pain while hacking with the UI code. Submitting knowledge and form 50 times a day is not fun at all. :-)
Overall PR looks good. Some minor review comments and noticed following two issues :
- It requires one more seed example for knowledge form, currently it has only 4 examples.
- When we click on the "Edit" PR, i think we can just remove the auto-fill button, because i think we don't need autofill in that scenario. Checking for
!skillEditFormData?.isEditFormthis condition should fix it.
Signed-off-by: Ash Evans <ash.evans@ibm.com>
… to match convention Signed-off-by: Ash Evans <ash.evans@ibm.com>
… to match convention in the skills form Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <70710356+aevo98765@users.noreply.github.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…b.com/aevo98765/ui into issue/instructlab#166/dev-form-filler
Member
Author
|
@vishnoianil g2g? |
Member
|
@aevo98765 great! work here, appreciate it, lot of devs will be happy with this feature :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will make Dev work that depend on filling the knowledge or skills for out faster. Functionality is not available outside of .env dev.