Skip to content

Fix knowledge edit feature#144

Merged
nerdalert merged 1 commit intoinstructlab:mainfrom
vishnoianil:fix-edit-knowledge
Sep 3, 2024
Merged

Fix knowledge edit feature#144
nerdalert merged 1 commit intoinstructlab:mainfrom
vishnoianil:fix-edit-knowledge

Conversation

@vishnoianil
Copy link
Member

@vishnoianil vishnoianil commented Sep 3, 2024

Use the same knowledge form for edit, that is used for submitting new knowledge. That way, we don't
have to maintain two version of the form for submit and edit.

@vishnoianil vishnoianil force-pushed the fix-edit-knowledge branch 2 times, most recently from 4653a4c to 68762f9 Compare September 3, 2024 21:40
Use the same knowledge form for edit, that it uses
for submitting new knowledge. That way, we don't
have to maintain two version of form for submit and
edit.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
@vishnoianil vishnoianil marked this pull request as ready for review September 3, 2024 21:45
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nerdalert nerdalert merged commit 4eafc99 into instructlab:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants