@Misjohns Can you please review the text that I wrote in the warning popup. Let me know if you have any suggestion about the text and in general about the popup warning itself.

@vishnoianil hi! I'm a content designer who works with Missy. Based off of our product design system, PatternFly, there are a few wording and formatting changes that I would advise.

Let me know what you think about this rewrite:

GitHub Access Permissions

To allow InstructLab UI to manage your taxonomy submissions, you must grant read and write permissions to your GitHub account. InstructLab UI will use your account to:

• Pull PRs from the upstream InstructLab Taxonomy repo that you’ve opened to contribute skill and knowledge.
• Fork the InstructLab Taxonomy repo to your GitHub account and create PRs from this fork, which can merge into the upstream Taxonomy repo.
• Fork the taxonomy-knowledge-docs repo to your GitHub account and upload knowledge-related documents from your account.

These permissions do not enable InstructLab UI to access your GitHub password.

To provide InstructLab UI with the permissions necessary for managing your taxonomy submissions, select accept. If you do not wish to grant these permissions, select deny to sign out of InstructLab UI.

GitHub Access Permissions

To allow InstructLab UI to manage your taxonomy submissions, you must grant read and write permissions to your GitHub account. InstructLab UI will use your account to:

• Pull PRs from the upstream InstructLab Taxonomy repo that you’ve opened to contribute skill and knowledge.
• Fork the InstructLab Taxonomy repo to your GitHub account and create PRs from this fork, which can merge into the upstream Taxonomy repo.
• Fork the taxonomy-knowledge-docs repo to your GitHub account and upload knowledge-related documents from your account.

These permissions do not enable InstructLab UI to access your GitHub password.

To provide InstructLab UI with the permissions necessary for managing your taxonomy submissions, select accept. If you do not wish to grant these permissions, select deny to sign out of InstructLab UI.

@edonehoo This looks great!, really appreciate the review. I was also thinking of adding the url to the "taxonomy" repo and "taxonomy-knowledge-docs" repo, so that user know what repo it is referring to. These links won't be visible in the warning popup, so i assume the change should be fine, but in case not, please let me know.

GitHub Access Permissions
To allow InstructLab UI to manage your taxonomy submissions, you must grant read and write permissions to your GitHub account. InstructLab UI will use your account to:

• Pull PRs from the upstream InstructLab Taxonomy repo that you’ve opened to contribute skill and knowledge.
• Fork the InstructLab Taxonomy repo to your GitHub account and create PRs from this fork, which can merge into the upstream Taxonomy repo.
• Fork the taxonomy-knowledge-docs repo to your GitHub account and upload knowledge-related documents from your account.

These permissions do not enable InstructLab UI to access your GitHub password.
To provide InstructLab UI with the permissions necessary for managing your taxonomy submissions, select accept. If you do not wish to grant these permissions, select deny to sign out of InstructLab UI.

@edonehoo This looks great!, really appreciate the review. I was also thinking of adding the url to the "taxonomy" repo and "taxonomy-knowledge-docs" repo, so that user know what repo it is referring to. These links won't be visible in the warning popup, so i assume the change should be fine, but in case not, please let me know.

This is how it looks now. Please let me know if it requires any other changes.

@vishnoianil I think links are a great idea! I think it would be most clear to include the entire phrase in the link text, so that users can better understand that the links lead to GH. So InstructLab Taxonomy repo and taxonomy-knowledge-docs repo.

And a couple of small final adjustments that I noticed:

• in the first bullet point, change "contribute skill" to plural "contribute skills".
• Add an extra line break at the end of the modal, between the two sentences beginning with "These permissions do not enable InstructLab...." and "To provide InstructLab UI with the permissions necessary..."

Otherwise, this is looking great to me!

@vishnoianil I think links are a great idea! I think it would be most clear to include the entire phrase in the link text, so that users can better understand that the links lead to GH. So InstructLab Taxonomy repo and taxonomy-knowledge-docs repo.

And a couple of small final adjustments that I noticed:

• in the first bullet point, change "contribute skill" to plural "contribute skills".
• Add an extra line break at the end of the modal, between the two sentences beginning with "These permissions do not enable InstructLab...." and "To provide InstructLab UI with the permissions necessary..."

Otherwise, this is looking great to me!

Addressed through another PR #133. Here is the latest snapshot.

The second text line of the bullets should align with the first line text instead of with the bullet.

The second text line of the bullets should align with the first line text instead of with the bullet.

I will take care of that in next PR, thanks for pointing that out @Misjohns