UI Crash on clear chat button fix#126
Merged
vishnoianil merged 3 commits intoinstructlab:mainfrom Aug 21, 2024
Merged
Conversation
dominikkawka
force-pushed
the
playgroundChatClear
branch
from
537b45d to
b004454
Compare
vishnoianil
approved these changes
Aug 21, 2024
Member
|
@dominikkawka Thanks for the PR, appreciate the contribution. Can you please run the UI linter and push the change. 'npm run lint:fix' should fix the UI linter failure. |
Signed-off-by: DominikKawka <dkawka@redhat.com>
This reverts commit b004454. Signed-off-by: DominikKawka <dkawka@redhat.com>
Signed-off-by: DominikKawka <dkawka@redhat.com>
dominikkawka
force-pushed
the
playgroundChatClear
branch
from
affcd0d to
397c49d
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on merge, close #124
When clicking the clear text button mid answer, the application won't crash anymore.
However it is still generating the answer, so when another question is asked, it will continue answering the previous question.
e.g. I asked to give a short description of Sherlock Holmes before clearing the text.