refactored the skill description#121
Merged
aevo98765 merged 2 commits intoinstructlab:mainfrom Sep 2, 2024
Merged
Conversation
Signed-off-by: Muhammad Mohammadi <muhammadmohammadis6@gmail.com>
aevo98765
requested changes
Aug 19, 2024
| import YamlCodeModal from '../../YamlCodeModal'; | ||
| import { AttributionData, SchemaVersion, SkillYamlData } from '@/types'; | ||
| import SkillDescription from './SkillDescription'; | ||
| import SkillDescription from './SkillDescription/SkillDescriptionContent'; |
Member
There was a problem hiding this comment.
This is not the correct component to import. You have imported just the content. The 'wrapper' component SkillDescription is what should be imported here.
If you run npm run dev you can see that the Expandable section is not being rendered.
Compare the your branches UI to the main branch UI and this should make sense.
Collaborator
Author
There was a problem hiding this comment.
thank you for bringing this to my attention, the rendering issue has been resolved.
Signed-off-by: Muhammad Mohammadi <muhammadmohammadis6@gmail.com>
aevo98765
approved these changes
Sep 2, 2024
Member
|
Thanks for this one @MuhammadKurdi-CS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored skill description