Issue/#94/refactor the knowledge submission form#111
Merged
vishnoianil merged 16 commits intoinstructlab:mainfrom Aug 19, 2024
Merged
Conversation
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
…icipate that this will be the main route of entry for most users Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
aevo98765
force-pushed
the
issue/#94/refactor-the-knowledge-submission-form
branch
from
88450c9 to
20e21a4
Compare
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
…r seed examples to be supported by typescript types Signed-off-by: Ash Evans <ash.evans@ibm.com>
…breaking change for the validation. Validation of form fields needs to be reevaluated Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
… Also validation moved Signed-off-by: Ash Evans <ash.evans@ibm.com>
…c sits upstream of both submit and yaml download in a knowledge validation file. This will be moved up above skills too when that is refactored Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Emilie Nouveau <dyannenova@gmail.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
aevo98765
force-pushed
the
issue/#94/refactor-the-knowledge-submission-form
branch
from
214d642 to
25000e5
Compare
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Member
|
@aevo98765 Awesome work!! Thanks for pulling this off. Appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The src/components/Contribute/Knowledgeindex.tsx has been refactored. Size now around 380 from 800 +. This code has been split out into individual components. Also the seedExamples have been typed which will help in future changes to the schema.
This will make future collaborative work on this form easier.
Feedback very welcome on this one. Sorry that it is a large one.