Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: instructlab/training
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: instructlab/training
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr-680
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Jan 27, 2026

  1. add support for mlflow

    @RobotSail
    RobotSail committed Jan 27, 2026
    Configuration menu
    Copy the full SHA
    d33da9a View commit details
    Browse the repository at this point in the history

  2. fix formatting changes

    @RobotSail
    RobotSail committed Jan 27, 2026
    Configuration menu
    Copy the full SHA
    d35920b View commit details
    Browse the repository at this point in the history

  3. Add tensorboard_log_dir to TrainingArgs for configurable TensorBoard … 

    …logging

- Add tensorboard_log_dir field to TrainingArgs in config.py
- Update setup_metric_logger to use tensorboard_log_dir when provided
- Add CLI argument for tensorboard_log_dir
- Wire tensorboard_log_dir through run_training() to subprocess command

This allows users to specify a custom directory for TensorBoard logs,
defaulting to output_dir if not specified.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
    @RobotSail @claude
    RobotSail and claude committed Jan 27, 2026
    Configuration menu
    Copy the full SHA
    866a47d View commit details
    Browse the repository at this point in the history

  4. Address PR review feedback 

    - Replace defensive getattr() with direct attribute access in main_ds.py
  since args are guaranteed to exist from argparse defaults
- Remove unused log_dir parameter from MLflowHandler
- Add debug logging for non-numeric metrics skipped by MLflowHandler

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
    @RobotSail @claude
    RobotSail and claude committed Jan 27, 2026
    Configuration menu
    Copy the full SHA
    5f1f071 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2026

  1. deletes run_name in favor of logger-specific run names

    @RobotSail
    RobotSail committed Jan 30, 2026
    Configuration menu
    Copy the full SHA
    017cb1b View commit details
    Browse the repository at this point in the history
Loading