Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

lint: Disable line length lint check#45

Merged
bjhargrave merged 1 commit intoinstructlab:mainfrom
bjhargrave:yamllint-no-line-length
Aug 22, 2024
Merged

lint: Disable line length lint check#45
bjhargrave merged 1 commit intoinstructlab:mainfrom
bjhargrave:yamllint-no-line-length

Conversation

@bjhargrave
Copy link
Contributor

When using markdown tables in qna.yaml files, for example, in a knowledge context as copied from a source knowledge markdown file, the markdown table rows can be quite wide. Often much wider than the current 120 char line length limit. Since a markdown table row cannot be split without breaking the table, we need to disable line length checks to support the use of markdown tables in qna.yaml.

@bjhargrave bjhargrave requested a review from juliadenham August 16, 2024 14:54
When using markdown tables in qna.yaml files, for example, in a
knowledge context as copied from a source knowledge markdown file,
the markdown table rows can be quite wide. Often much wider than the
current 120 char line length limit. Since a markdown table row cannot
be split without breaking the table, we need to disable line length
checks to support the use of markdown tables in qna.yaml.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Copy link

@juliadenham juliadenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjhargrave bjhargrave merged commit a049a4d into instructlab:main Aug 22, 2024
@bjhargrave bjhargrave deleted the yamllint-no-line-length branch August 22, 2024 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants