Use schema repository via submodule#913
Merged
hickeyma merged 2 commits intoinstructlab:mainfrom Apr 29, 2024
Merged
Conversation
bjhargrave
requested review from
Tomcli,
abhi1092,
afrittoli,
anik120,
hickeyma,
markstur,
mrutkows,
soltysh,
spzala and
xukai92
as code owners
bjhargrave
force-pushed
the
schema-submodule
branch
2 times, most recently
from
4adb763 to
4fb8924
Compare
This was referenced Apr 18, 2024
Contributor
|
Could you please mention submodules in the README? Contributors now have to clone the project with |
bjhargrave
force-pushed
the
schema-submodule
branch
from
4fb8924 to
1d403e5
Compare
bjhargrave
requested review from
jeremyeder,
kelbrown20 and
mairin
as code owners
github-actions
bot
added
the
documentation
bjhargrave
force-pushed
the
schema-submodule
branch
from
1d403e5 to
eb4a775
Compare
Member
|
Looks like this needs rebase - is there anything else needed for this PR before merging? |
bjhargrave
force-pushed
the
schema-submodule
branch
from
eb4a775 to
1ed6aa4
Compare
Contributor
Author
Done! |
Contributor
Author
I don't think so. The taxonomy repo is now using submodule to incorporate the schema files. |
bjhargrave
force-pushed
the
schema-submodule
branch
from
1ed6aa4 to
7a1da8e
Compare
bjhargrave
added a commit
to bjhargrave/instructlab_instructlab
that referenced
this pull request
Apr 25, 2024
We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. Fixes instructlab#989 Depends on instructlab#913 and instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
This avoids the need to duplicate the schema files in this repository. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Since the taxonomy repo now uses submodules, we want to clone the complete view of the repo. Docs are updated to mention submodule use by the instructlab and taxonomy repositories. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
bjhargrave
force-pushed
the
schema-submodule
branch
from
7a1da8e to
276533a
Compare
bjhargrave
added a commit
to bjhargrave/instructlab_instructlab
that referenced
this pull request
Apr 29, 2024
We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. Fixes instructlab#989 Depends on instructlab#913 and instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
bjhargrave
added a commit
to bjhargrave/instructlab_instructlab
that referenced
this pull request
Apr 29, 2024
We introduce a relaxed schema as v1 which will accept all existing taxonomy files in the main branch of the taxonomy repo. The current v1 schema is renamed to v2 and will be used for future contributions to the taxonomy repo. Fixes instructlab#989 Depends on instructlab#913 and instructlab/schema#11 Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Partial #760
Description of your changes:
This avoids the need to duplicate the schema files in this repository.
Also, since the taxonomy repo now uses submodules, we want to clone the
complete view of the repo.