chore: Uncap requires-python in package metadata#3293
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Apr 19, 2025
Merged
chore: Uncap requires-python in package metadata#3293mergify[bot] merged 1 commit intoinstructlab:mainfrom
mergify[bot] merged 1 commit intoinstructlab:mainfrom
Conversation
This blocks people from trying the package out on newer Python versions without hacks. A good expose on why upper caps are in general a bad idea and should be avoided can be found at: https://iscinumpy.dev/post/bound-version-constraints/ (Look for 'Pinning the Python version is special' title.) Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
nathan-weinberg
approved these changes
Apr 17, 2025
reidliu41
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This blocks people from trying the package out on newer Python versions
without hacks. A good expose on why upper caps are in general a bad idea
and should be avoided can be found at:
https://iscinumpy.dev/post/bound-version-constraints/
(Look for 'Pinning the Python version is special' title.)
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com
Checklist:
conventional commits.