chore: bump the training library to 0.8.0 and refactor tokenizer usage#3250
Merged
jaideepr97 merged 2 commits intoinstructlab:mainfrom Apr 8, 2025
Merged
chore: bump the training library to 0.8.0 and refactor tokenizer usage#3250jaideepr97 merged 2 commits intoinstructlab:mainfrom
jaideepr97 merged 2 commits intoinstructlab:mainfrom
Conversation
RobotSail
force-pushed
the
update-training
branch
from
0b4549f to
2417c2a
Compare
mergify
bot
added
ci-failure
Member
|
also noticed that there are new linting failures because docling recently released a new version that includes this PR that has new fields in some of their APIs that we use (docling-project/docling#1010) which is getting pulled in probably needs to be fixed in a separate PR |
Closed
Signed-off-by: Oleg Silkin <97077423+RobotSail@users.noreply.github.com>
jaideepr97
force-pushed
the
update-training
branch
from
39b942d to
d27eba6
Compare
mergify
bot
added
ci-failure
Signed-off-by: Jaideep Rao <jrao@redhat.com>
jaideepr97
force-pushed
the
update-training
branch
from
d27eba6 to
fa90e6a
Compare
jaideepr97
approved these changes
Apr 8, 2025
cdoern
approved these changes
Apr 8, 2025
alinaryan
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release of instructlab-training improves the usage for tokenizing datasets by removing the requirement of needing to always supply a chat template. This breaks the API for
setup_tokenizerwhere in the past it needed to be passed some special objects only present in the training library. Now, it accepts only the model path and an optional template path. And given the scenario, it will automatically configure the tokenizer to the best of its abilities.Checklist:
conventional commits.