infra: default cloud-instance.sh to latest CentOS 9 AMI#3248
Merged
mergify[bot] merged 1 commit intomainfrom Apr 2, 2025
Merged
infra: default cloud-instance.sh to latest CentOS 9 AMI#3248mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
booxter
reviewed
Mar 27, 2025
If the cloud-init.sh user has not hard-coded an AMI ID in ~/.instructlab/cloud-config, default to using the newest CentOS 9 AMI that the CPE team has published to the AWS marketplace. The purpose of this change is to make it easier to launch the latest cloud images with fewer security vulnerabilities. Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
ktdreyer
force-pushed
the
latest-centos-9-ami
branch
from
d46dfd5 to
6515813
Compare
booxter
approved these changes
Apr 2, 2025
danmcp
approved these changes
Apr 2, 2025
Member
|
Nice change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
cloud-init.shuser has not hard-coded an AMI ID in~/.instructlab/cloud-config, default to using the newest CentOS 9 AMI that the CPE team has published to the AWS marketplace.The purpose of this change is to make it easier to launch the latest cloud images with fewer security vulnerabilities.
To test this, I've run
cloud-instance.shwith the following scenarios:EC2_AMI_ID="ami-09fc0e32ec75bfe3f"in~/.instructlab/cloud-configcontinues to launch the old AMIEC2_AMI_IDfrom in~/.instructlab/cloud-configproperly selects the latest CentOS image, anddnfshows no pending updates on the node.