Skip to content

Fix import of read_config in debug-llama#3212

Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom
radeksm:bugfix/read_config
Mar 5, 2025
Merged

Fix import of read_config in debug-llama#3212
mergify[bot] merged 1 commit intoinstructlab:mainfrom
radeksm:bugfix/read_config

Conversation

@radeksm
Copy link
Contributor

@radeksm radeksm commented Mar 1, 2025 •
edited
Loading

Function read_config() has been moved from instructlab.config to instructlab.configuration module.

Fix below problem with import of read_config() function which simply has been moved to different place.

(instructlab-02-cuda) ai@box ~/s/instructlab (main)> ./containers/bin/debug-llama
llama_cpp version: 0.3.6
llama supports gpu offload: False
n_gpu_layers: -1 (gpu)
Traceback (most recent call last):
  File "/home/ai/src/instructlab/./containers/bin/debug-llama", line 74, in <module>
    main()
  File "/home/ai/src/instructlab/./containers/bin/debug-llama", line 36, in main
    from instructlab.config import read_config
ImportError: cannot import name 'read_config' from 'instructlab.config' (/home/ai/venv/instructlab-02-cuda/lib64/python3.11/site-packages/instructlab/config/__init__.py

@radeksm
Fix import of read_config in debug-llama
2b5a289 
Function read_config() has been moved from instructlab.config
to instructlab.configuration module.

Signed-off-by: Radoslaw Smigielski <rsmigiel@redhat.com>
@mergify mergify bot added the container Affects containization aspects label Mar 1, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Mar 5, 2025
@mergify mergify bot merged commit b7b04b4 into instructlab:main Mar 5, 2025
6 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@danmcp danmcp danmcp approved these changes

@reidliu41 reidliu41 reidliu41 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

container Affects containization aspects

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radeksm @danmcp @reidliu41