feat(infra): add cloud-instance list command; ignore shutting-down instances#3198
Merged
mergify[bot] merged 2 commits intoinstructlab:mainfrom Feb 27, 2025
Merged
Conversation
booxter
force-pushed
the
cloud-infra-list-terminating
branch
from
922b962 to
f757d38
Compare
danmcp
reviewed
Feb 27, 2025
booxter
force-pushed
the
cloud-infra-list-terminating
branch
from
f757d38 to
3e76e49
Compare
6 tasks
The command lists all matching ids. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
shutting-down means `The instance is preparing to be terminated.` as per: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-lifecycle.html Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
booxter
force-pushed
the
cloud-infra-list-terminating
branch
from
3e76e49 to
e48c5ea
Compare
danmcp
approved these changes
Feb 27, 2025
courtneypacheco
approved these changes
Feb 27, 2025
Contributor
courtneypacheco
left a comment
courtneypacheco
left a comment
There was a problem hiding this comment.
This is a good change. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements to the
cloud-instance.shscript:Checklist:
conventional commits.