ci: disable spell check#3133
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Feb 14, 2025
Merged
Conversation
We'd like to see if disabling spell check will make us agregeously ilitarate. ;) If the experiment doesn't go well, we can revert this patch later. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
jwm4
approved these changes
Feb 11, 2025
Contributor
jwm4
left a comment
jwm4
left a comment
There was a problem hiding this comment.
I think this is a good idea.
Contributor
|
I think this is a good compromise and would like to go ahead with merging this change. I want others to give their feedback though, so I won't formally approve it until others have had the chance to weigh in. |
ktdreyer
approved these changes
Feb 11, 2025
courtneypacheco
added
the
hold
courtneypacheco
approved these changes
Feb 11, 2025
Contributor
courtneypacheco
left a comment
courtneypacheco
left a comment
There was a problem hiding this comment.
I'm approving this PR and putting a hold for now until others can chime in. If everyone is ok with this by Friday, we can remove the hold and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to see if disabling spell check will make us agregeously
ilitarate. ;) If the experiment doesn't go well, we can revert this
patch later.
This is a follow-up to #3130
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com
Checklist:
conventional commits.