mypy: Remove use of undefined GGUFWriter symbols#1287
Closed
booxter wants to merge 1 commit intoinstructlab:mainfrom
Closed
mypy: Remove use of undefined GGUFWriter symbols#1287booxter wants to merge 1 commit intoinstructlab:mainfrom
booxter wants to merge 1 commit intoinstructlab:mainfrom
Conversation
Neither add_expert_count nor add_expert_used_count are defined in the version of gguf library we use. Actually, these symbols are not yet released on pypi, and are available in git repo of the library only: ggml-org/llama.cpp@799a1cb This makes mypy complain about it. This patch removes code related to these parameters. If and when we upgrade to gguf version that supports them, we may revert this patch. Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
Contributor
Author
|
Overall, this module seems to be a copy-pasted version of UPD: nevermind, I think I understand now: the file is not part of the gguf library, so it's impossible to get it through a package... I guess we'll maintain it ourselves then. But then the question is - do we want to enable mypy checks for the code that is not fully owned by us? What's the policy for this file? |
Contributor
Author
|
Squashed this into #1275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither add_expert_count nor add_expert_used_count are defined in the version of gguf library we use. Actually, these symbols are not yet released on pypi, and are available in git repo of the library only:
ggml-org/llama.cpp@799a1cb
This makes mypy complain about it.
This patch removes code related to these parameters. If and when we upgrade to gguf version that supports them, we may revert this patch.