This repository was archived by the owner on May 25, 2021. It is now read-only.
Feat/replace value with iri as string or implicit to string #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erm (with .toString()).
NSeydoux
approved these changes
May 22, 2020
Collaborator
NSeydoux
left a comment
NSeydoux
left a comment
There was a problem hiding this comment.
The package-lock.json contains references to a local verdaccio, and should be cleaned up before merging. Otherwise, looks good.
package.json
Outdated
| { | ||
| "name": "@inrupt/solid-react-components", | ||
| "version": "0.5.3", | ||
| "version": "0.5.4", |
Collaborator
There was a problem hiding this comment.
The version change should be featured in its own commit, in order to be able to tag it.
Contributor
Author
There was a problem hiding this comment.
Yeah, good point - I'll try to remember to discuss that with Jack as we do the release!
| */ | ||
| const coreNotificationShape = | ||
| 'https://shexshapes.inrupt.net/public/notifications/app-notification.shex'; | ||
| 'https://shexshapes.inrupt.net/public/notifications/core-notification.shex'; |
Collaborator
There was a problem hiding this comment.
I recall we had a discussion about this in a previous PR, but I don't remember the conclusion we reached. Should this change be kept or reverted ?
Contributor
Author
There was a problem hiding this comment.
Yeah, I reverted this change after chatting with Kevin.
ajacksified
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.