This repository was archived by the owner on May 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers from the dropdown
Release/0.5.0
Updating notifications to use relative node names
prevent mobile devices keyboard to pop up on selecting the pod provid…
Swapping 'from' to 'category' to align with requirements better
Refactor the form renderer in edit mode
Bugfix/saving
Feature/form model viewer
Updated existing, older tests so that they render on each test. The sequential testing was causing issues with the render not being there as expected.
When a checkbox value is null or undefined, also set it to not be checked. This helps with some issues regarding the default values.
Re-render withAuthorization in each test
* Upgraded to latest shexjs/core version * Revamped the shexjs code so it is no longer looping over each file sequentially * Made updates so the shex code returns a list of valid data's quads * Updated the parsing code so it no longer re-fetches the code * Renamed solidLDFlex to data so it is more in line with code samples of ldflex package
The issue was that the login page made the assumption that the WebID was hosted on the same origin as the Identity Provider, which is not necessarily the case. This fix adds a check on the `solid:oidcIssuer` predicate in the Profile Document to get the Identity Provider address, while remaining backwards compatible by also testing the presence of the IdP at the WebID origin.
Co-Authored-By: Vincent <Vinnl@users.noreply.github.com>
* Refactored out the .foreach for a map/filter combo * Added additional commenting to make the code clearer to newcomers
Refactor the notification validation, retrieval
Fixed WebID login bug
FormModel tests
Fixing issue with idp-url login
* Changing from using .id to .value, the .value uses the proper getter for the quad, so the .id was using double quotes around everything, which broke formatting of items and parsing of strings
Fixing issue with notification formatting
* During a refactor, a line of code was ommitted in error. The code still ran, but a display error was introduced when actor name and profile image were not there.
* Removed extraneous check for existance. This field exists, because it passed shex validation * Added comment to that effect
Fixing issue with notification display
* Added back in extraneously removed code that generates a path, id, and inboxname from the validated notification data. Without this, the notifications cannot be clicked as there's no subject to set as read/unread
Bug fix where path and id were absent
* If a checkbox field is set to null but used like a react component, it creates an error in the console about switching from controlled to uncontrolled field.
Bug/checkbox rendering
* Updated version number * Updated forms version to RC version * Npm audit fix for vulnerabilities
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.