This repository was archived by the owner on May 25, 2021. It is now read-only.
Update DateTime to use browser locales #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownhoward
changed the title
james-martin-jd
suggested changes
Dec 11, 2019
src/lib/utils/datetimes.js
Outdated
| */ | ||
| export const getFormattedLocale = (): string => { | ||
| const locale = getLocale().split('-'); | ||
| if (locale[1]) { |
Contributor
There was a problem hiding this comment.
This may be clearer if it's a length check instead
Contributor
Author
There was a problem hiding this comment.
Updated to check if locale.length > 1
james-martin-jd
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getFormattedLocaleas its own function in@libgetClosestLocaleto simplifly using localesgetClosestLocale