Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Updating game list retrieval #309

Merged
pmcb55 merged 2 commits into from
Apr 3, 2020
Merged

Updating game list retrieval #309

pmcb55 merged 2 commits into from
Apr 3, 2020

Conversation

@james-martin-jd
Copy link
Contributor

@james-martin-jd james-martin-jd commented Apr 2, 2020

  • Updating game list so that the new validateList function is used
  • Instead of fetching the game again, we parse the values from a list of quads instead

@james-martin-jd
Updating game list retrieval
a0eec11 
* Updating game list so that the new validateList function is used
* Instead of fetching the game again, we parse the values from a list of quads instead
pmcb55
pmcb55 reviewed Apr 3, 2020
View reviewed changes
@james-martin-jd james-martin-jd requested a review from pmcb55 April 3, 2020 14:01
pmcb55
pmcb55 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@pmcb55 pmcb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmcb55 pmcb55 merged commit 379367c into develop Apr 3, 2020
@pmcb55 pmcb55 deleted the bug/game-list-parsing branch April 3, 2020 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pmcb55 pmcb55 pmcb55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@james-martin-jd @pmcb55