This repository was archived by the owner on May 25, 2021. It is now read-only.
Adding check for predicate to loop over for the game list. This solve… #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the problem where only other people's games showed up in the list. The root cause is that we changed predicates to schema:hasPart, but that's only applicable to external games, not self-created ones.
angelaraya
suggested changes
Jan 3, 2020
Contributor
angelaraya
left a comment
angelaraya
left a comment
There was a problem hiding this comment.
Mostly styling changes to keep it in sync with the other libs.
| * If it is not a container, we are using schema:hasPart so we don't confuse it with a container | ||
| * schema:hasPart is used for externally linked games in other people's pods | ||
| */ | ||
| if (typeValue && typeValue === LDPVocabulary.BASICCONTAINER) { |
Contributor
There was a problem hiding this comment.
The === should be enough. No need to use && to check if typeValue is falsy.
| /** | ||
| * Object containing a reference to the UI ontology's IRIs | ||
| */ | ||
| export const LDPVocabulary = { |
Contributor
There was a problem hiding this comment.
For the components library I'm using the following convention for vocabs:
/* vocabs.js */
const lpdBase = `http://www.w3.org/ns/ldp#`
export const LPD = {
BASIC_CONTAINER: `${lpdBase}BasicContainer`,
};/* client.js */
import { LPD } from '@vocabs';
...It's up to you if you want to use the same idea here until we use LIT.
| if (!document) return gameList; | ||
| for await (const item of document['schema:hasPart']) { | ||
|
|
||
| const type = await document['rdf:type']; |
Contributor
There was a problem hiding this comment.
Move these strings (schema:hasPart too) to a const value.
angelaraya
approved these changes
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s the problem where only other people's games showed up in the list. The root cause is that we changed predicates to schema:hasPart, but that's only applicable to external games, not self-created ones.