This repository was archived by the owner on May 25, 2021. It is now read-only.
added app permission message error #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-martin-jd
suggested changes
Jul 26, 2019
generators/app/templates/.env
Outdated
| REACT_APP_TICTAC_PATH=public/games/tictactoe/ | ||
| REACT_APP_TICTAC_PATH=public/test2/tictactoe/ | ||
| REACT_APP_VERSION=$npm_package_version | ||
| REACT_APP_PERMISSIONS=Append,Control,Read,Write |
Contributor
There was a problem hiding this comment.
Why is this part of the config? Don't these modes come from the components? They aren't app-specific but rather solid specific
Contributor
Author
There was a problem hiding this comment.
@james-martin-jd, This is an app-specific it's not for a component I think this should be here, all the generator needs these permissions to works so needs to be global and not for a component.
Contributor
There was a problem hiding this comment.
Right, but I meant I thought there was a service/class that provided this list in the ACL library?
Contributor
Author
There was a problem hiding this comment.
These are the permissions for the app it's not related to ACL library.
generators/app/templates/src/layouts/PrivateLayout/private.layout.js
Outdated
Show resolved
Hide resolved
james-martin-jd
approved these changes
Jul 31, 2019
generators/app/templates/src/layouts/PrivateLayout/private.layout.js
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need components PR: inrupt/solid-react-components#109