Running stitch length sequence #4034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # and via imports also runs on generate-inx-files, which with the Nix | ||
| # package manager is executed with a non-writable home directory. | ||
| user_dir = get_user_dir(create=False) | ||
| user_dir = get_user_dir(create=True) |
Collaborator
There was a problem hiding this comment.
Why did you change this? This again broke the build on NixOS. See the comment above it for the reasoning.
Collaborator
Author
There was a problem hiding this comment.
We got mutiple error message reports on this from users who tried the dev builds. But I think it's been fixed elsewhere. I honestly don't remember, I'll revert this change and will check again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All stroke style stitch types (except for manual stitch of course), can now enter multiple values into the stitch length field to create a pattern.
Pattern may be influenced by running stitch tolerance. For a strict pattern increase tolerance value. In this case, stitches may cut sharp corners.