Open
Conversation
Contributor
|
Thanks! |
inducer
reviewed
Jul 12, 2022
| elif isinstance(insn, (NoOpInstruction, BarrierInstruction)): | ||
| pass | ||
| elif isinstance(insn, (CInstruction, NoOpInstruction, BarrierInstruction)): | ||
| exprs_in_insn = tuple(insn.predicates) |
Owner
There was a problem hiding this comment.
Since we don't know how much computation goes on in a CInstruction, I think we at least need a flag to turn on this behavior, since it's easy to have misconceptions on what it does.
Collaborator
Author
|
@inducer: This is ready for another look! |
Contributor
|
Can we add something similar so I don't run into the same error with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @sv2518.