add redo function into command pattern#46
Merged
Conversation
zhwbqd
commented
Apr 15, 2015
zhwbqd
commented
- add redo function into command pattern.
- add .iml and .idea into .gitignore
Contributor
There was a problem hiding this comment.
just thinking...
can we make undo()/redo() (as well as execute()) return boolean instead of void, so we can't shrink if no target provided, target already shrinked (small) or target is immune.
as result command can't be queued/dequeued if execute() fails.
Owner
|
This looks good to me. The queues make the example more realistic. |
Owner
|
Returning boolean from undo()/redo()/execute() is ok too, if you want to add that. Let me know when you're done with the changes and I will merge the PR. |
iluwatar
added a commit
that referenced
this pull request
Apr 17, 2015
add redo function into command pattern
pratigya0
pushed a commit
to pratigya0/java-design-patterns
that referenced
this pull request
Aug 3, 2023
Add linux answer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.