docs: Improve existing German READMEs and add new ones#3444
docs: Improve existing German READMEs and add new ones#3444sieberss wants to merge 32 commits intoiluwatar:masterfrom
Conversation
PR SummaryLocalized and expanded German READMEs for Java Design Patterns: revamped central German README, updated Abstract Document content, and added new German READMEs with diagrams for multiple patterns, plus numerous new UML/images to support localization. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
Files Processed (2)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
Actionable Comments (0)
Skipped Comments (6)
-
localization/de/README.md [1-4]
readability: "Inconsistency in badge wording"
-
localization/de/README.md [14-15]
readability: "Language list and link consistency"
-
localization/de/README.md [19-24]
readability: "Intro copy consistency"
-
localization/de/README.md [37-37]
readability: "Terminology consistency"
-
localization/de/README.md [47-50]
readability: "Book section language and capitalization"
-
localization/de/README.md [54-54]
readability: "License phrasing"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 398d4f5: Create folder for Abstract Factory
Files Processed (3)
- localization/de/Abstract Factory (1 hunk)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
Actionable Comments (1)
-
localization/de/abstract-document/README.md [88-92]
readability: "Narrative text inside code block breaks Java code snippet."
Skipped Comments (9)
-
localization/de/Abstract Factory [1-1]
maintainability: "Remove empty placeholder file or replace with a valid README."
-
localization/de/README.md [1-4]
readability: "Check German title and top-section localization."
-
localization/de/README.md [11-16]
readability: "Add language navigation links."
-
localization/de/README.md [37-37]
readability: "Verify list formatting and language consistency in new bullets."
-
localization/de/README.md [45-50]
readability: "Add book section; fix minor localization typos."
-
localization/de/README.md [54-54]
readability: "License phrasing"
-
localization/de/abstract-document/README.md [3-11]
readability: "Localize front-matter tags."
-
localization/de/abstract-document/README.md [238-245]
readability: "Clarify advantages/disadvantages section layout."
-
localization/de/abstract-document/README.md [246-249]
readability: "Remove/handle affiliate links in sources."
| // Weitere Eigenschaften und Methoden... | ||
| } | ||
| ``` | ||
| Als nächstes definieren wir ein Enum Property und eine Menge von Schnittstellen für Typ, Preis, Modell und Teile. Dies ermöglicht es uns, eine statisch aussehende Schnittstelle für unsere Car-Klasse zu erstellen. | ||
| Als nächstes definieren wir ein Enum `Property` und je eine Schnittstelle für Typ, Preis, Modell und Teile. So können wir eine statisch aussehende Schnittstelle für unsere Klasse `Car` erstellen. | ||
|
|
There was a problem hiding this comment.
Narrative explanations were inserted inside a Java code block, which will break syntax. Move these explanations outside the code block or convert to code comments.
There was a problem hiding this comment.
They are outside the code block
|
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- e71866f: Create README.md for Abstract Document
Files Processed (1)
- localization/de/abstract-factory/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (8)
-
localization/de/abstract-factory/README.md [19-21]
readability: "Grammatik und Stil verbessern"
-
localization/de/abstract-factory/README.md [23-23]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [25-29]
readability: "Bilingual content inconsistency"
-
localization/de/abstract-factory/README.md [31-31]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [35-35]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [39-39]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [172-172]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [190-190]
readability: "Übersetzung von Überschriften"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 624e970: Translate README.md for Abstract Document to German
Files Processed (1)
- localization/de/abstract-factory/README.md (1 hunk)
Actionable Comments (1)
-
localization/de/abstract-factory/README.md [36-36]
typo: "Typo: 'Klassse' → 'Klasse'"
Skipped Comments (4)
-
localization/de/abstract-factory/README.md [40-40]
readability: "Bildpfad fehlerhaft: UML-Diagramm-Datei"
-
localization/de/abstract-factory/README.md [90-90]
readability: "Markdown-Codeblock falsch beendet"
-
localization/de/abstract-factory/README.md [146-146]
readability: "Ungenauigkeit im Beispielpfad"
-
localization/de/abstract-factory/README.md [199-205]
readability: "Formatter-Fehler: leere Bulletzeilen"
|
|
||
| Wikipedia sagt | ||
|
|
||
| > Das Abstract-Factory-Pattern dient zur Kapselung einer Gruppe einzelner Factories mit gemeinsamem Thema, wobei deren konkrete Klassse variabel bleibt. |
There was a problem hiding this comment.
Typo in German translation: 'Klassse' ist falsch geschrieben. Korrigiere zu 'Klasse'.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- b91d1f7: correct typo
Files Processed (1)
- localization/de/abstract-factory/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
localization/de/abstract-factory/README.md [89-89]
readability: "Inconsistent Orc/Ork terminology in sample code"
-
localization/de/abstract-factory/README.md [143-155]
readability: "Usage example has incorrect/type reference and naming"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (10)
- a1c4254: docs: Create German README.md for Active Object
#2275
first text part
- b1061ff: docs: add missing words in abstract-factory.README.md
(#2275) - 908b93d: docs: add class diagrams for all patterns
(#2275) - b91d1f7: correct typo
- 624e970: Translate README.md for Abstract Document to German
- e71866f: Create README.md for Abstract Document
- 398d4f5: Create folder for Abstract Factory
- 325b272: docs: reformulate german translation for Abstract Document
(#2275) - ca43940: docs: shorten text for link to payhip
(#2275) - 5f9e2d2: docs: reformulate text, add links to further languages and paragraph about the book in central README.md
(#2275)
Files Processed (30)
- localization/de/Abstract Factory (1 hunk)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
- localization/de/abstract-factory/README.md (1 hunk)
- localization/de/abstract-factory/etc/abstract-factory.urm.png (0 hunks)
- localization/de/active-object/README.md (1 hunk)
- localization/de/active-object/etc/active-object.urm.png (0 hunks)
- localization/de/adapter/etc/adapter.urm.png (0 hunks)
- localization/de/aggregator-microservices/aggregator-service/etc/aggregator-service.png (0 hunks)
- localization/de/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/de/api-gateway/etc/api-gateway.png (0 hunks)
- localization/de/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/de/balking/etc/balking.png (0 hunks)
- localization/de/bridge/etc/bridge.urm.png (0 hunks)
- localization/de/builder/etc/builder.urm.png (0 hunks)
- localization/de/business-delegate/etc/business-delegate.urm.png (0 hunks)
- localization/de/bytecode/etc/bytecode.urm.png (0 hunks)
- localization/de/chain-of-responsibility/etc/chain-of-responsibility.urm.png (0 hunks)
- localization/de/client-session/etc/session_state_pattern.png (0 hunks)
- localization/de/collecting-parameter/etc/collecting-parameter.urm.png (0 hunks)
- localization/de/command/etc/command.png (0 hunks)
- localization/de/commander/etc/commander.urm.png (0 hunks)
- localization/de/composite-entity/etc/composite_entity.urm.png (0 hunks)
- localization/de/composite-view/etc/composite_view.png (0 hunks)
- localization/de/composite-view/etc/images/noparam.png (0 hunks)
- localization/de/composite-view/etc/images/threeparams.png (0 hunks)
- localization/de/composite/etc/composite.urm.png (0 hunks)
- localization/de/context-object/etc/context-object.png (0 hunks)
- localization/de/converter/etc/converter.png (0 hunks)
- localization/de/crtp/etc/crtp.png (0 hunks)
Actionable Comments (1)
-
localization/de/abstract-document/README.md [128-137]
best_practice: "Narrative inside code block"
Skipped Comments (7)
-
localization/de/Abstract Factory [1-1]
maintainability: "Invalid path due to spaces in directory name"
-
localization/de/README.md [1-1]
best_practice: "Front matter consistency"
-
localization/de/README.md [14-15]
readability: "Multilingual links formatting"
-
localization/de/README.md [19-27]
readability: "German introductory copy quality"
-
localization/de/README.md [37-37]
readability: "Terminology consistency (patterns category)"
-
localization/de/README.md [41-50]
readability: "German grammar and consistency in Mitarbeit section"
-
localization/de/abstract-document/README.md [1-16]
maintainability: "Front matter localization inconsistencies"
| Nun können wir das `Car` einführen. | ||
|
|
||
| ```java | ||
| public static void main(String[] args) { | ||
| LOGGER.info("Konstruktion von Teilen und Auto"); | ||
|
|
||
| var wheelProperties = Map.of( | ||
| Property.TYPE.toString(), "wheel", | ||
| Property.MODEL.toString(), "15C", | ||
| Property.PRICE.toString(), 100L); | ||
|
|
||
| var doorProperties = Map.of( | ||
| Property.TYPE.toString(), "door", | ||
| Property.MODEL.toString(), "Lambo", | ||
| Property.PRICE.toString(), 300L); | ||
|
|
||
| var carProperties = Map.of( | ||
| Property.MODEL.toString(), "300SL", | ||
| Property.PRICE.toString(), 10000L, | ||
| Property.PARTS.toString(), List.of(wheelProperties, doorProperties)); | ||
|
|
||
| var car = new Car(carProperties); | ||
|
|
||
| LOGGER.info("Hier ist unser Auto:"); | ||
| LOGGER.info("-> Modell: {}", car.getModel().orElseThrow()); | ||
| LOGGER.info("-> Preis: {}", car.getPrice().orElseThrow()); | ||
| LOGGER.info("-> Teile: "); | ||
| public class Car extends AbstractDocument implements HasModel, HasPrice, HasParts { | ||
|
|
||
| public Car(Map<String, Object> properties) { | ||
| super(properties); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
The German instructional text between code blocks should be placed outside the Java code blocks. Narrative comments inside a code block can break compilation when copied as code; move non-code explanations to prose sections or convert to Java comments inside the code.
sieberss
changed the title
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (1)
- localization/de/actor-model/README.md (1 hunk)
Actionable Comments (2)
-
localization/de/actor-model/README.md [35-35]
typo: "Typo in German translation"
-
localization/de/actor-model/README.md [175-175]
typo: "Typo in benefits section"
Skipped Comments (4)
-
localization/de/actor-model/README.md [107-110]
readability: "Language consistency in code sample"
-
localization/de/actor-model/README.md [113-113]
readability: "Inconsistent ID capitalization"
-
localization/de/actor-model/README.md [2-12]
maintainability: "Front matter translation consistency"
-
localization/de/actor-model/README.md [178-178]
readability: "Inconsistent terminology for 'actors' plural"
| Stellen Sie sich ein Kundendienstsystem vor. | ||
| - Jeder **Kundendienstmitarbeiter** ist ein **Aktor**. | ||
| - Kunden **senden Anfragen (Nachrichten)** an die Mitarbeiter. | ||
| - Jeder Mitarbeiter behandelt zu einem bestimmten Zeitpunkt genau eine Anfrage und kann diese **asychron beantworten**, |
There was a problem hiding this comment.
Typo detected: the German line uses the misspelling 'asychron'. It should be 'asynchron' (or 'asynchron').
| ## Vor- und Nachteile | ||
|
|
||
| ### ✅ Benefits | ||
| - Unterstützt hohes Maß an Parellelität |
There was a problem hiding this comment.
Typo: 'Parellelität' should be 'Parallelität'.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (14)
- 0fdb2f6: docs: translate actor-model into German
- 362646e: docs: finish German translation of README.md for Active Object
- a1c4254: docs: Create German README.md for Active Object
#2275
first text part
- b1061ff: docs: add missing words in abstract-factory.README.md
(#2275) - 908b93d: docs: add class diagrams for all patterns
(#2275) - b91d1f7: correct typo
- 624e970: Translate README.md for Abstract Document to German
- e71866f: Create README.md for Abstract Document
- 398d4f5: Create folder for Abstract Factory
- 325b272: docs: reformulate german translation for Abstract Document
(#2275) - ca43940: docs: shorten text for link to payhip
(#2275) - 5f9e2d2: docs: reformulate text, add links to further languages and paragraph about the book in central README.md
(#2275)
Files Processed (30)
- localization/de/Abstract Factory (1 hunk)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
- localization/de/abstract-factory/README.md (1 hunk)
- localization/de/abstract-factory/etc/abstract-factory.urm.png (0 hunks)
- localization/de/active-object/README.md (1 hunk)
- localization/de/active-object/etc/active-object.urm.png (0 hunks)
- localization/de/actor-model/README.md (1 hunk)
- localization/de/acyclic-visitor/README.md (1 hunk)
- localization/de/adapter/etc/adapter.urm.png (0 hunks)
- localization/de/aggregator-microservices/aggregator-service/etc/aggregator-service.png (0 hunks)
- localization/de/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/de/api-gateway/etc/api-gateway.png (0 hunks)
- localization/de/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/de/balking/etc/balking.png (0 hunks)
- localization/de/bridge/etc/bridge.urm.png (0 hunks)
- localization/de/builder/etc/builder.urm.png (0 hunks)
- localization/de/business-delegate/etc/business-delegate.urm.png (0 hunks)
- localization/de/bytecode/etc/bytecode.urm.png (0 hunks)
- localization/de/chain-of-responsibility/etc/chain-of-responsibility.urm.png (0 hunks)
- localization/de/client-session/etc/session_state_pattern.png (0 hunks)
- localization/de/collecting-parameter/etc/collecting-parameter.urm.png (0 hunks)
- localization/de/command/etc/command.png (0 hunks)
- localization/de/commander/etc/commander.urm.png (0 hunks)
- localization/de/composite-entity/etc/composite_entity.urm.png (0 hunks)
- localization/de/composite-view/etc/composite_view.png (0 hunks)
- localization/de/composite-view/etc/images/noparam.png (0 hunks)
- localization/de/composite-view/etc/images/threeparams.png (0 hunks)
- localization/de/composite/etc/composite.urm.png (0 hunks)
- localization/de/context-object/etc/context-object.png (0 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
localization/de/Abstract Factory [1-1]
maintainability: "Remove empty placeholder file or add content"
-
localization/de/README.md [1-4]
readability: "German root README header update"
-
localization/de/abstract-document/README.md [14-16]
readability: "Add/verify Zweck section in Abstract Document README"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (30)
- localization/de/Abstract Factory (1 hunk)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
- localization/de/abstract-factory/README.md (1 hunk)
- localization/de/abstract-factory/etc/abstract-factory.urm.png (0 hunks)
- localization/de/active-object/README.md (1 hunk)
- localization/de/active-object/etc/active-object.urm.png (0 hunks)
- localization/de/actor-model/README.md (1 hunk)
- localization/de/acyclic-visitor/README.md (1 hunk)
- localization/de/adapter/etc/adapter.urm.png (0 hunks)
- localization/de/aggregator-microservices/aggregator-service/etc/aggregator-service.png (0 hunks)
- localization/de/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/de/api-gateway/etc/api-gateway.png (0 hunks)
- localization/de/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/de/balking/etc/balking.png (0 hunks)
- localization/de/bridge/etc/bridge.urm.png (0 hunks)
- localization/de/builder/etc/builder.urm.png (0 hunks)
- localization/de/business-delegate/etc/business-delegate.urm.png (0 hunks)
- localization/de/bytecode/etc/bytecode.urm.png (0 hunks)
- localization/de/chain-of-responsibility/etc/chain-of-responsibility.urm.png (0 hunks)
- localization/de/client-session/etc/session_state_pattern.png (0 hunks)
- localization/de/collecting-parameter/etc/collecting-parameter.urm.png (0 hunks)
- localization/de/command/etc/command.png (0 hunks)
- localization/de/commander/etc/commander.urm.png (0 hunks)
- localization/de/composite-entity/etc/composite_entity.urm.png (0 hunks)
- localization/de/composite-view/etc/composite_view.png (0 hunks)
- localization/de/composite-view/etc/images/noparam.png (0 hunks)
- localization/de/composite-view/etc/images/threeparams.png (0 hunks)
- localization/de/composite/etc/composite.urm.png (0 hunks)
- localization/de/context-object/etc/context-object.png (0 hunks)
Actionable Comments (2)
-
localization/de/actor-model/README.md [186-199]
typo: "Typo in German Actor Model README"
-
localization/de/Abstract Factory [1-1]
maintainability: "Invalid file name with spaces"
Skipped Comments (2)
-
localization/de/abstract-document/README.md [85-92]
best_practice: "Narrative text inside code block"
-
localization/de/README.md [37-37]
readability: "Inconsistent bullet formatting"
| ## Verwandte Patterns | ||
|
|
||
| - [Command Pattern](../command) | ||
| - [Mediator Pattern](../mediator) | ||
| - [Event-Driven Architecture](../event-driven-architecture) | ||
| - [Observer Pattern](../observer) | ||
|
|
||
| --- | ||
|
|
||
| ## Quellen | ||
|
|
||
| - *Programming Erlang*, Joe Armstrong | ||
| - *Reactive Design Patterns*, Roland Kuhn | ||
| - *The Actor Model in 10 Minutes*, [InfoQ Article](https://www.infoq.com/articles/actor-model/) |
There was a problem hiding this comment.
Typographical errors were flagged in the German README. Correct the typos to improve readability: 'asychron' should be 'asynchron' (or 'asynchron'), and 'Parellelität' should be 'Parallelität'.
localization/de/Abstract Factory
Outdated
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
An added file path with a space in the name likely indicates a misplacement. This should probably be a directory (localization/de/abstract-factory/) containing a README.md, rather than a top-level file named 'Abstract Factory'.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- e05a119: Delete localization/de/Abstract Factory
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 95b7014: insert line break
Files Processed (1)
- localization/de/abstract-document/README.md (4 hunks)
Actionable Comments (1)
-
localization/de/abstract-document/README.md [166-170]
possible bug: "Potential issue with log formatting of car parts."
Skipped Comments (4)
-
localization/de/abstract-document/README.md [129-138]
readability: "Add Car skeleton for README example."
-
localization/de/abstract-document/README.md [139-173]
best_practice: "Narrative text inside code blocks should be moved out."
-
localization/de/abstract-document/README.md [3-3]
consistency: "Inconsistent front matter category language."
-
localization/de/abstract-document/README.md [8-8]
consistency: "German consistency in tags."
| car.getParts().forEach(p -> LOGGER.info("\t{}/{}/{}", | ||
| p.getType().orElse(null), | ||
| p.getType().orElse(null), | ||
| p.getModel().orElse(null), | ||
| p.getPrice().orElse(null)) | ||
| ); |
There was a problem hiding this comment.
Ensure the log line's placeholders match the provided values. The snippet uses 3 placeholders ({}/{}/{}), and the code passes 3 values (type, model, price). Verify that Part#getType() exists on the Part interface; if not, the snippet will fail to compile. Consider aligning the placeholders with available fields.
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (20)
- 3779cbc: realignment of java code block
- 1d14af5: correct typos in actor-model
- 95b7014: insert line break
- e05a119: Delete localization/de/Abstract Factory
- 0816c93: docs: Translate Prototype into German
- 12fd4e0: docs: Translate Singleton into German
- 0fdb2f6: docs: translate actor-model into German
- 362646e: docs: finish German translation of README.md for Active Object
- a1c4254: docs: Create German README.md for Active Object
#2275
first text part
- b1061ff: docs: add missing words in abstract-factory.README.md
(#2275) - 908b93d: docs: add class diagrams for all patterns
(#2275) - b91d1f7: correct typo
- 624e970: Translate README.md for Abstract Document to German
- e71866f: Create README.md for Abstract Document
- 398d4f5: Create folder for Abstract Factory
- 325b272: docs: reformulate german translation for Abstract Document
(#2275) - ca43940: docs: shorten text for link to payhip
(#2275) - 5f9e2d2: docs: reformulate text, add links to further languages and paragraph about the book in central README.md
(#2275)
Files Processed (30)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
- localization/de/abstract-factory/README.md (1 hunk)
- localization/de/abstract-factory/etc/abstract-factory.urm.png (0 hunks)
- localization/de/active-object/README.md (1 hunk)
- localization/de/active-object/etc/active-object.urm.png (0 hunks)
- localization/de/actor-model/README.md (1 hunk)
- localization/de/acyclic-visitor/README.md (1 hunk)
- localization/de/adapter/etc/adapter.urm.png (0 hunks)
- localization/de/aggregator-microservices/aggregator-service/etc/aggregator-service.png (0 hunks)
- localization/de/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/de/api-gateway/etc/api-gateway.png (0 hunks)
- localization/de/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/de/balking/etc/balking.png (0 hunks)
- localization/de/bridge/etc/bridge.urm.png (0 hunks)
- localization/de/builder/etc/builder.urm.png (0 hunks)
- localization/de/business-delegate/etc/business-delegate.urm.png (0 hunks)
- localization/de/bytecode/etc/bytecode.urm.png (0 hunks)
- localization/de/chain-of-responsibility/etc/chain-of-responsibility.urm.png (0 hunks)
- localization/de/client-session/etc/session_state_pattern.png (0 hunks)
- localization/de/collecting-parameter/etc/collecting-parameter.urm.png (0 hunks)
- localization/de/command/etc/command.png (0 hunks)
- localization/de/commander/etc/commander.urm.png (0 hunks)
- localization/de/composite-entity/etc/composite_entity.urm.png (0 hunks)
- localization/de/composite-view/etc/composite_view.png (0 hunks)
- localization/de/composite-view/etc/images/noparam.png (0 hunks)
- localization/de/composite-view/etc/images/threeparams.png (0 hunks)
- localization/de/composite/etc/composite.urm.png (0 hunks)
- localization/de/context-object/etc/context-object.png (0 hunks)
- localization/de/converter/etc/converter.png (0 hunks)
Actionable Comments (2)
-
localization/de/README.md [3-3]
typo: "Typo: license badge capitalization"
-
localization/de/README.md [29-29]
typo: "Typographical error in introduction"
Skipped Comments (2)
-
localization/de/README.md [14-14]
readability: "Language code mismatch for Nepali link"
-
localization/de/abstract-document/README.md [92-92]
readability: "Narrative text inside code block"
| # In Java implementierte Entwurfsmuster | ||
| # Design Patterns (Entwurfsmuster) in Java | ||
|
|
||
|  |
There was a problem hiding this comment.
Capitalize the license badge word in German: 'lizenz' should be 'Lizenz' for proper German capitalization.
There was a problem hiding this comment.
there is neither 'lizenz' nor 'Lizenz' in the cited line.
| Diese Seite präsentiert Entwurfsmuster für Java. Die Lösungen wurden von erfahrenen Programmierern und Architekten aus der Open-Source-Community entwickelt. Die Muster können entweder anhand ihrer Beschreibungen oder durch den Quellcode erkundet werden. Die Codebeispiele sind gut kommentiert und eignen sich als Tutorials, wie das jeweilige Muster zu implementieren ist. Wir verwenden dabei bekannte und bewährte Open-Source-Java-Technologien. | ||
|
|
||
| Bevor Sie sich mit den Entwurfsmustern beschäftigen, sollten Sie sich mit den grundlegenden [Software-Entwurfsprinzipien](https://java-design-patterns.com/principles/) vertraut machen. | ||
| Ehe Sie tiefer in den Stoff eindringen, sollten Sie sich mit den grundlegenden [Software-Entwurfsprinzipien](https://java-design-patterns.com/principles/) vertraut machen. |
There was a problem hiding this comment.
Typo: 'Ehe' should be 'Bevor' or 'Bevor Sie' for correct German phrasing.
There was a problem hiding this comment.
'Ehe' means the same as 'Bevor'.
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (30)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
- localization/de/abstract-factory/README.md (1 hunk)
- localization/de/abstract-factory/etc/abstract-factory.urm.png (0 hunks)
- localization/de/active-object/README.md (1 hunk)
- localization/de/active-object/etc/active-object.urm.png (0 hunks)
- localization/de/actor-model/README.md (1 hunk)
- localization/de/acyclic-visitor/README.md (1 hunk)
- localization/de/adapter/README.md (1 hunk)
- localization/de/adapter/etc/adapter.urm.png (0 hunks)
- localization/de/aggregator-microservices/aggregator-service/etc/aggregator-service.png (0 hunks)
- localization/de/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/de/api-gateway/etc/api-gateway.png (0 hunks)
- localization/de/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/de/balking/etc/balking.png (0 hunks)
- localization/de/bridge/etc/bridge.urm.png (0 hunks)
- localization/de/builder/etc/builder.urm.png (0 hunks)
- localization/de/business-delegate/etc/business-delegate.urm.png (0 hunks)
- localization/de/bytecode/etc/bytecode.urm.png (0 hunks)
- localization/de/chain-of-responsibility/etc/chain-of-responsibility.urm.png (0 hunks)
- localization/de/client-session/etc/session_state_pattern.png (0 hunks)
- localization/de/collecting-parameter/etc/collecting-parameter.urm.png (0 hunks)
- localization/de/command/etc/command.png (0 hunks)
- localization/de/commander/etc/commander.urm.png (0 hunks)
- localization/de/composite-entity/etc/composite_entity.urm.png (0 hunks)
- localization/de/composite-view/etc/composite_view.png (0 hunks)
- localization/de/composite-view/etc/images/noparam.png (0 hunks)
- localization/de/composite-view/etc/images/threeparams.png (0 hunks)
- localization/de/composite/etc/composite.urm.png (0 hunks)
- localization/de/context-object/etc/context-object.png (0 hunks)
Actionable Comments (4)
-
localization/de/README.md [1-4]
typo: "License badge capitalization in German README"
-
localization/de/README.md [29-31]
typo: "Grammatik: Bevor statt Ehe"
-
localization/de/abstract-document/README.md [88-90]
maintainability: "Narrative text inside code block in Abstract Document README"
-
localization/de/actor-model/README.md [195-199]
typo: "Typo in German Actor Model README"
Skipped Comments (1)
-
localization/de/abstract-document/README.md [92-100]
maintainability: "Move narrative out of code block; ensure code blocks contain code only"
localization/de/README.md
Outdated
| # Design Patterns (Entwurfsmuster) in Java | ||
|
|
||
|  | ||
| [](https://raw.githubusercontent.com/iluwatar/java-design-patterns/master/LICENSE.md) |
There was a problem hiding this comment.
German license badge text uses lowercase 'lizenz' in the badge URL. Capitalize to 'Lizenz' to match German capitalization and ensure consistency with the German readme. The alt/text currently shows 'Lizenz MIT' which is fine, but the URL path should reflect capitalization.
| Ehe Sie tiefer in den Stoff eindringen, sollten Sie sich mit den grundlegenden [Software-Entwurfsprinzipien](https://java-design-patterns.com/principles/) vertraut machen. | ||
|
|
||
| Entwürfe sollten immer so einfach wie möglich gehalten werden. Beginnen Sie mit den Prinzipien KISS (Keep It Simple, Stupid), YAGNI (You Aren’t Gonna Need It) und "Do The Simplest Thing That Could Possibly Work". Komplexe Muster sollten nur dann verwendet werden, wenn sie wirklich notwendig sind. | ||
| Entwürfe sollten immer so einfach wie möglich gehalten werden. Beginnen Sie mit den Prinzipien KISS (Keep It Simple, Stupid), YAGNI (You Aren’t Gonna Need It) und "Do The Simplest Thing That Could Possibly Work". Komplexere Strukturen und Muster sollten erst dann verwendet werden, wenn sie wirklich notwendig sind. |
There was a problem hiding this comment.
Ehe Sie tiefer in den Stoff eindringen, sollten Sie sich mit den grundlegenden Software-Entwurfsprinzipien vertraut machen.
Entwürfe sollten immer so einfach wie möglich gehalten werden. Beginnen Sie mit den Prinzipien KISS (Keep It Simple, Stupid), YAGNI (You Aren’t Gonna Need It) und "Do The Simplest Thing That Could Possibly Work". Komplexere Strukturen und Muster sollten erst dann verwendet werden, wenn sie wirklich notwendig sind.
| // Weitere Eigenschaften und Methoden... | ||
| } | ||
| ``` |
There was a problem hiding this comment.
// Weitere Eigenschaften und Methoden...
}
<!-- presubmit.ai: comment -->
| ## Quellen | ||
|
|
||
| - *Programming Erlang*, Joe Armstrong | ||
| - *Reactive Design Patterns*, Roland Kuhn | ||
| - *The Actor Model in 10 Minutes*, [InfoQ Article](https://www.infoq.com/articles/actor-model/) |
There was a problem hiding this comment.
Typo: 'asychron' should be 'asynchron' (or 'asynchron'), and 'Parellelität' should be 'Parallelität'.
change 'lizenz' to 'Lizenz' in badge
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (1)
- localization/de/README.md (2 hunks)
Actionable Comments (1)
-
localization/de/README.md [27-27]
typo: "Typo/phrasing: replace 'Ehe' with 'Bevor'"
Skipped Comments (2)
-
localization/de/README.md [49-49]
readability: "German grammar: mixed languages and capitalization"
-
localization/de/README.md [54-54]
readability: "German phrasing for license terms"
| # Erste Schritte | ||
|
|
||
| Diese Seite stellt Java-Entwurfsmuster vor. Die Lösungen wurden von erfahrenen Entwicklern und Architekten aus der Open-Source-Community erstellt. Die Muster können entweder durch ihre Beschreibungen oder durch den Quellcode erkundet werden. Die Codebeispiele sind gut kommentiert und eignen sich als Tutorials, um die Muster zu verstehen und umzusetzen. Wir verwenden dabei bekannte und bewährte Open-Source-Java-Technologien. | ||
| Diese Seite präsentiert Entwurfsmuster für Java. Die Lösungen wurden von erfahrenen Programmierern und Architekten aus der Open-Source-Community entwickelt. Die Muster können entweder anhand ihrer Beschreibungen oder durch den Quellcode erkundet werden. Die Codebeispiele sind gut kommentiert und eignen sich als Tutorials, wie das jeweilige Muster zu implementieren ist. Wir verwenden dabei bekannte und bewährte Open-Source-Java-Technologien. |
There was a problem hiding this comment.
German phrasing: 'Ehe' is incorrect here. Use 'Bevor' (Bevor Sie ...) for proper meaning and sentence structure.
translate 'benefits' and 'trade-offs'
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (1)
- localization/de/actor-model/README.md (1 hunk)
Actionable Comments (2)
-
localization/de/actor-model/README.md [108-108]
typo: "Typo in code comment: possessive pronoun"
-
localization/de/actor-model/README.md [109-109]
typo: "Typo in code comment: possessive pronoun"
Skipped Comments (1)
-
localization/de/actor-model/README.md [55-55]
readability: "Broken image path in UML diagram"
| public class ActorSystem { | ||
| public void startActor(Actor actor) { | ||
| String actorId = "actor-" + idCounter.incrementAndGet(); // Generate a new and unique ID | ||
| actor.setActorId(actorId); // assign the actor it's ID |
There was a problem hiding this comment.
Typo in possessive pronoun in code comment. 'it's' should be 'its'.
| public void startActor(Actor actor) { | ||
| String actorId = "actor-" + idCounter.incrementAndGet(); // Generate a new and unique ID | ||
| actor.setActorId(actorId); // assign the actor it's ID | ||
| actorRegister.put(actorId, actor); // Register and save the actor with it's ID |
There was a problem hiding this comment.
Typo in possessive pronoun in code comment. 'it's' should be 'its'.
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- d531c43: remove additional bullet point after line break
Files Processed (1)
- localization/de/actor-model/README.md (1 hunk)
Actionable Comments (3)
-
localization/de/actor-model/README.md [107-107]
possible bug: "Thread-safety: actor ID generation"
-
localization/de/actor-model/README.md [109-109]
typo: "Typo: incorrect possessive in code comment"
-
localization/de/actor-model/README.md [112-114]
possible bug: "Potential concurrency issue with actor lookup"
Skipped Comments (2)
-
localization/de/actor-model/README.md [118-118]
enhancement: "Graceful shutdown recommendation"
-
localization/de/actor-model/README.md [66-66]
best_practice: "Immutability of actorId"
| ```java | ||
| public class ActorSystem { | ||
| public void startActor(Actor actor) { | ||
| String actorId = "actor-" + idCounter.incrementAndGet(); // Generate a new and unique ID |
There was a problem hiding this comment.
Potential race condition: id generation relies on idCounter; ensure idCounter is thread-safe (e.g., AtomicLong) and properly initialized before use.
| public void startActor(Actor actor) { | ||
| String actorId = "actor-" + idCounter.incrementAndGet(); // Generate a new and unique ID | ||
| actor.setActorId(actorId); // assign the actor it's ID | ||
| actorRegister.put(actorId, actor); // Register and save the actor with it's ID |
There was a problem hiding this comment.
Typo: possessive pronoun should be 'its' not 'it's' in the comment.
| public Actor getActorById(String actorId) { | ||
| return actorRegister.get(actorId); // Find by Id | ||
| } |
There was a problem hiding this comment.
getActorById delegates to actorRegister.get(actorId) without synchronization; if this map is accessed concurrently, consider using a ConcurrentHashMap or synchronization to avoid data races.
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 1287d25: correct indentation
Files Processed (1)
- localization/de/actor-model/README.md (1 hunk)
Actionable Comments (2)
-
localization/de/actor-model/README.md [109-112]
typo: "Fix possessive typo in ID handling comments"
-
localization/de/actor-model/README.md [114-116]
possible bug: "Concurrency: protect actorRegister access"
Skipped Comments (2)
-
localization/de/actor-model/README.md [82-84]
possible bug: "Implement a working Actor.run loop"
-
localization/de/actor-model/README.md [95-97]
maintainability: "Remove unused setter on immutable Message fields"
| String actorId = "actor-" + idCounter.incrementAndGet(); // Generate a new and unique ID | ||
| actor.setActorId(actorId); // assign the actor it's ID | ||
| actorRegister.put(actorId, actor); // Register and save the actor with it's ID | ||
| executor.submit(actor); // Run the actor in a thread |
There was a problem hiding this comment.
Typo in the comments: 'it's' should be 'its' in the actor ID related lines. Fix for both occurrences.
| public Actor getActorById(String actorId) { | ||
| return actorRegister.get(actorId); // Find by Id | ||
| } |
There was a problem hiding this comment.
getActorById accesses actorRegister without synchronization. If actorRegister is a shared map accessed from multiple threads, consider using a concurrent map or synchronizing access to avoid data races.
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (1)
- localization/de/bridge/README.md (1 hunk)
Actionable Comments (2)
-
localization/de/bridge/README.md [45-45]
typo: "Typo: Bridge pattern name"
-
localization/de/bridge/README.md [235-238]
typo: "German typos in technical terms"
Skipped Comments (2)
-
localization/de/bridge/README.md [56-57]
readability: "Language consistency"
-
localization/de/bridge/README.md [50-50]
maintainability: "Diagram asset path"
localization/de/bridge/README.md
Outdated
|
|
||
| Wikipedia sagt | ||
|
|
||
| > Das Bride-Pattern ist ein Entwurfsmuster der Softwareentwicklung mit dem Zweck, |
There was a problem hiding this comment.
Typo: The Bridge pattern is referred to as 'Bride-Pattern'. This should be 'Bridge-Pattern' for consistency with the naming used elsewhere in the repo.
| * Sie wollen eine Implementation mit mehreren Objekten teilen, eventuell unter Verwendung von | ||
| Referenzzählerm, dabei aber dieses Detail aber vor den Verwendern verstecken. Beispiel dafür | ||
| ist Copliens String-Klasse, wo mehrere Objekte die gleiche Stringdarstellung haben. | ||
|
|
There was a problem hiding this comment.
Typos and inconsistent naming in a German translation: 'Referenzzählerm' should be 'Referenzzählers' and 'Copliens' should be 'Coplien's' (with apostrophe). Also ensure proper punctuation around these clauses.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 489ed10: correct typos
Files Processed (1)
- localization/de/bridge/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
localization/de/bridge/README.md [54-57]
readability: "German translation quality: mixed English sample included"
-
localization/de/bridge/README.md [62-73]
readability: "Java sample readability and compatibility"
sieberss
changed the title
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 3ae1ecb: docs: Translate Builder into German
Files Processed (1)
- localization/de/builder/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
localization/de/builder/README.md [29-29]
readability: "Fix stray English text in German README"
-
localization/de/builder/README.md [35-35]
readability: "Typo in German translation"
-
localization/de/builder/README.md [210-212]
readability: "Translate English bullet points in Nachteile"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 9a13083: delete english text
Files Processed (1)
- localization/de/builder/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (5)
-
localization/de/builder/README.md [12-14]
readability: "Verbesserung der Formulierung"
-
localization/de/builder/README.md [63-66]
readability: "Satzbau in Beispieltext verbessern"
-
localization/de/builder/README.md [105-105]
readability: "Kleiner Rechtschreib-/Stilfehler in Demonstrationscode"
-
localization/de/builder/README.md [142-145]
best_practice: "Hinweis zur Java-Version bei 'var'-Verwendung"
-
localization/de/builder/README.md [57-57]
maintainability: "Diagram image link may be broken"
change link to image
|
1 participant
Issue #2275
What does this PR do?
reformulation of existing README files (Main and Abstract Document) in German
add links to further languages in Main README
add paragraph for the book
translate README files of other patterns into German