Skip to content

Formatted spacing and updated documentation#3290

Merged
iluwatar merged 2 commits intoiluwatar:masterfrom
ronodhirSoumik:bugfix/added-spacing-refactoration
Jan 17, 2026
Merged

Formatted spacing and updated documentation#3290
iluwatar merged 2 commits intoiluwatar:masterfrom
ronodhirSoumik:bugfix/added-spacing-refactoration

Conversation

@ronodhirSoumik
Copy link
Contributor

@ronodhirSoumik ronodhirSoumik commented May 31, 2025

Pull Request Template

What does this PR do?

This pull request formats redundant spacing in common pom.xml and rewrites documentation for removeSubscriber function of Publish-Subscribe model.

@github-actions
Copy link

github-actions bot commented May 31, 2025 •
edited
Loading

PR Summary

This PR refactors redundant spacing in the pom.xml file and updates the documentation for the removeSubscriber function in the Publish-Subscribe model. The pom.xml file's module list is reformatted to remove redundant spacing, improving readability. The documentation for the removeSubscriber function is updated for clarity and accuracy.

Changes

File Summary
pom.xml Refactored redundant spacing in the module list, improving readability and maintainability. No functional changes were introduced.
publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/model/Topic.java Updated documentation for the removeSubscriber function. The description now clearly states that the function removes a subscriber from the list of subscribers.

autogenerated by presubmit.ai

github-actions[bot]
github-actions bot reviewed May 31, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

Review Summary

Commits Considered (2)
  • 7330bd9: Updated documentation of remove subscriber in publish-subscribe model
  • 7d50833: Refactored redundant spacing in pom.xml
Files Processed (2)
  • pom.xml (2 hunks)
  • publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/model/Topic.java (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
  • pom.xml [234-234]

    readability: "Inconsistent indentation in pom.xml"

  • pom.xml [247-248]

    readability: "Inconsistent indentation in pom.xml"

  • publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/model/Topic.java [53-57]

    enhancement: "Add usage example to removeSubscriber documentation"

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 31, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ronodhirSoumik ronodhirSoumik changed the title Bugfix/added spacing refactoration Formatted spacing and updated documentation May 31, 2025
@github-actions
Copy link

github-actions bot commented Jul 31, 2025

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Jul 31, 2025
@iluwatar iluwatar merged commit 98d3601 into iluwatar:master Jan 17, 2026
2 checks passed
@iluwatar
Copy link
Owner

iluwatar commented Jan 17, 2026

@all-contributors please add @ronodhirSoumik for docs

@allcontributors allcontributors bot mentioned this pull request Jan 17, 2026
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jan 17, 2026

@iluwatar

I've put up a pull request to add @ronodhirSoumik! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@iluwatar iluwatar iluwatar approved these changes

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ronodhirSoumik @iluwatar