Merged
Conversation
PR SummaryThis PR adds Persian translations for several Java design pattern documentation files. The goal is to improve accessibility for Persian-speaking developers. Specifically, it translates the Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 6b334d9: Persian Translation: Add codes to README.md of abstract-document
Files Processed (2)
- localization/fa/abstract-document/README.md (1 hunk)
- localization/fa/abstract-document/etc/abstract-document.png (0 hunks)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- c91155b: Persian Translation: some improvements in abstract-document
Files Processed (1)
- localization/fa/abstract-document/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 0943a85: active-object : translate
Files Processed (4)
- localization/fa/active-object/README.md (1 hunk)
- localization/fa/active-object/etc/active-object-sequence-diagram.png (0 hunks)
- localization/fa/active-object/etc/active-object.urm.png (0 hunks)
- localization/fa/active-object/etc/active-object.urm.puml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 0319089: active-object: improve when to use
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 2772918: active-object: improve when to use
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
localization/fa/active-object/README.md [50-52]
enhancement: "Improve connection between Orc example and Active Object pattern."
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- c8f4023: active-object: improve bullets (test)
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 5725830: active-object: improve bullets (test)
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
localization/fa/active-object/README.md [17-17]
readability: "Grammatical error on line 17."
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- b14e48b: active-object: improve bullets (test)
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 9921861: active-object: improve bullets (test)
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 937a17e: active-object: improve bullets
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- f3e283d: active-object: Fix all bullets
Files Processed (1)
- localization/fa/active-object/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
localization/fa/active-object/README.md [17-17]
readability: "Grammatical error in sentence structure."
-fixed alignment in bullets
-changed tags to English
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (7)
- ba5872a: Update README.md
-changed tags to English
- 155e20b: Update README.md
-fixed alignment in bullets
Files Processed (2)
- localization/fa/factory/README.md (1 hunk)
- localization/fa/factory/etc/factory-sequence-diagram.png (0 hunks)
Actionable Comments (0)
Skipped Comments (0)
|
iluwatar
approved these changes
Apr 22, 2025
Owner
|
@all-contributors please add @maziyar-gerami for translation |
Contributor
|
I've put up a pull request to add @maziyar-gerami! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
It is a big task and this pull request will be completed step by step.
What does this PR do?
This pull request adds the initial Persian (Farsi) translation for selected design pattern documentation files in the
docsdirectory.The purpose is to make the java-design-patterns project more accessible to Persian-speaking developers.
Fixes #3035