Message Channel EIP #227

iluwatar · 2015-08-22T16:50:29Z

JDP core team, please review. This is the first implemented EIP. I've used Apache Camel for the implementation.

Resolves #143

bernardosulzbach · 2015-08-25T19:25:33Z

Any way to improve the distribution of the elements of the image?

iluwatar · 2015-08-27T16:56:28Z

Hand adjusted the class diagram. Should be more readable now.

bernardosulzbach · 2015-08-27T17:17:09Z

message-channel/.gitignore

@iluwatar Why duplicated?

bernardosulzbach · 2015-08-27T17:24:45Z

The diagram is better now. Did some code review.

bernardosulzbach · 2015-08-27T20:39:12Z

Will this commits be squashed together before merging, right?

npathai · 2015-09-01T10:54:24Z

message-channel/src/main/java/com/iluwatar/message/channel/App.java

Another way of saying that would be that "Message Channel decouples Message producers and Consumers".

Yes. But if producers is lowercase, consumers should also be. Not a problem in the comment, but wouldn't be right on the code.

@mafagafogigante 👍 a typo

This is done.

bernardosulzbach · 2015-09-02T18:55:09Z

Will you squash this before merging to keep the story clean?

bernardosulzbach · 2015-09-02T18:55:49Z

Also, you can do git pull --rebase ... to avoid that useless merge commit.

iluwatar · 2015-09-02T20:06:09Z

See Reviewing pull requests.

Message Channel EIP

bernardosulzbach · 2015-09-02T20:09:40Z

So screw VCS history readability? Fantastic.

iluwatar · 2015-09-02T20:20:59Z

@mafagafogigante At the moment we have not agreed on requirement to squash everything before merge. We can discuss this on Gitter.

iluwatar added 6 commits August 22, 2015 14:54

#143 Skeleton for Message Channel EIP example

c4912b2

#143 Added Camel dependency

cd4d420

#143 Work on the example code

acd7070

#143 Improve example code and add class diagram

b3574e5

#143 Commented the example

96dc4cd

#143 Added pattern description to index.md

6b94390

#143 Nicer layout for the class diagram

c745baa

bernardosulzbach reviewed Aug 27, 2015
View reviewed changes

message-channel/.gitignore Outdated

Copy link

Contributor

bernardosulzbach Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iluwatar Why duplicated?

iluwatar added 2 commits August 27, 2015 20:59

#143 Fixed duplicate line in .gitignore

2fc778a

#143 Fix intendation in pom.xml

e5ef5db

npathai reviewed Sep 1, 2015
View reviewed changes

iluwatar added 4 commits September 2, 2015 21:23

#143 Improved example documentation

b99d2b7

#143 Added second message channel.

f74c8c2

#143 Added real world example

4fc4409

Merge branch 'master' into message-channel

ed82081

#143 Fixed version number

b5d03b6

iluwatar added a commit that referenced this pull request Sep 2, 2015

Merge pull request #227 from iluwatar/message-channel

e33d037

Message Channel EIP

iluwatar merged commit e33d037 into master Sep 2, 2015

iluwatar deleted the message-channel branch September 2, 2015 20:16

Uh oh!

Message Channel EIP #227

Message Channel EIP #227

Uh oh!

Conversation

iluwatar commented Aug 22, 2015

Uh oh!

bernardosulzbach commented Aug 25, 2015

Uh oh!

iluwatar commented Aug 27, 2015

Uh oh!

bernardosulzbach Aug 27, 2015

Choose a reason for hiding this comment

Uh oh!

bernardosulzbach commented Aug 27, 2015

Uh oh!

bernardosulzbach commented Aug 27, 2015

Uh oh!

npathai Sep 1, 2015

Choose a reason for hiding this comment

Uh oh!

bernardosulzbach Sep 1, 2015

Choose a reason for hiding this comment

Uh oh!

npathai Sep 2, 2015

Choose a reason for hiding this comment

Uh oh!

iluwatar Sep 2, 2015

Choose a reason for hiding this comment

Uh oh!

bernardosulzbach commented Sep 2, 2015

Uh oh!

bernardosulzbach commented Sep 2, 2015

Uh oh!

iluwatar commented Sep 2, 2015

Uh oh!

bernardosulzbach commented Sep 2, 2015

Uh oh!

iluwatar commented Sep 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants