Conversation
servant/pom.xml
Outdated
There was a problem hiding this comment.
Delete this line (groupId), comes from the parent pom.xml
|
You should also add servant module to the parent pom.xml in the modules section: https://github.com/sideris/java-design-patterns/blob/master/pom.xml |
|
Please let me know when you've done the changes. |
|
Done. Sorry, I moved it to an external project, because I had problems with Eclipse. |
|
Travis seems to be down. I broke Travis 👍 |
servant/pom.xml
Outdated
There was a problem hiding this comment.
No need for url element here - please remove.
|
It does not compile at the moment. Please see my comments and fix accordingly. Let me know when you are done. |
|
Changed them. Travis still down. |
|
Thank you for the contribution! Somehow the methods don't fit into their boxes in the UML diagram. Can you check this? Also can you share me the GenMyModel project? What is the source of the Servant pattern (i.e. book, url...)? |
|
From this paper mostly: http://edu.pecinovsky.cz/papers/2006_ITiCSE_Design_Patterns_First.pdf I noticed that too. I changed it to ObjectAid |
|
We could add the paper in the Credits section of the README.md |
|
I will do that when I'm back from Cambridge. If you have any patterns to suggest please do. |
|
Lots of patterns to implement here: http://en.wikipedia.org/wiki/Software_design_pattern |
|
I added the paper you mentioned to the Credits section of the |
|
@all-contributors please add @sideris for code |
|
I've put up a pull request to add @sideris! 🎉 |
2 participants
Adding the servant pattern and relevant diagrams(GenMyModel generated)