Merged
Conversation
|
This pull request is automatically deployed with Now. |
james9909
reviewed
Apr 27, 2019
Member
james9909
left a comment
james9909
left a comment
There was a problem hiding this comment.
Overall looks like a pretty good base to start with. Don't forget the changelog entry!
Contributor
Author
|
Did my best to add a suitable linting config for TypeScript - there's a bit of weird duplication of some rules between JS and TS and I had to add some overrides since there's not great built-in support for dual-language projects in |
james9909
approved these changes
Apr 29, 2019
Member
james9909
left a comment
james9909
left a comment
There was a problem hiding this comment.
LGTM, we can clean up the ESLint config whenever we fully convert to TypeScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #220. This PR by no means converts fully to TypeScript, but it does add it to our toolchain so that we can incrementally add types in the future. The build process is a little wonky given that Next doesn't support transpiling server files itself (see vercel/next.js#1735) so we have to work around that. I'm going to write docs explaining what I did and why I did it so that if problems come up in the future, future maintainers have something to go off of.
TODO