Merged
Conversation
|
This pull request is automatically deployed with Now. |
james9909
reviewed
Apr 15, 2019
Member
james9909
left a comment
james9909
left a comment
There was a problem hiding this comment.
Looks pretty good to me!
One small thing though: the autocomplete results on the admin page still render as white
Contributor
Author
|
Good catch! Should be fixed now. |
jackieo5023
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a site-wide, persistent, per-device dark mode toggle that applies ~60 lines of CSS to override key Bootstrap attributes. I've tested it on every page on the site and it's looking pretty good:
This does add a bit of overhead to future changes, as we might have to further tweak styles to account for using new Bootstrap features. However, I think it's worth it.