Use transactions to fix socket update errors#262
Merged
nwalters512 merged 3 commits intomasterfrom Apr 7, 2019
Merged
Conversation
|
This pull request is automatically deployed with Now. |
james9909
reviewed
Apr 7, 2019
Member
james9909
left a comment
james9909
left a comment
There was a problem hiding this comment.
Since we're adding our own modified version of sequelize-stream, can we remove it as a dependency?
Contributor
Author
|
Yep, good call! Would also be nice to contribute these changes back to |
james9909
approved these changes
Apr 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in the Sequelize docs, Sequelize uses a transaction internally for operations like
findOrCreate, which is precisely the method that the active staff API uses when adding staff members. I believe this fact is causing #92 - there's a race condition where we try to read a tuple before the transaction that creates it has been committed. This PR modifies the code fromsequelize-streamto make theoptionsobject available to event listeners so that we can useoptions.transactionas appropriate.Closes #92 (just over a year after it was reported!)