Conversation
iliaal
force-pushed
the
fix/openssl-ss004-pre-verify-truncation
branch
from
September 10, 2026 22:10
05ab82f to
4cf1136
Compare
…succeeds openssl_pkcs7_verify() and openssl_cms_verify() opened the content and p7b output paths in write mode before verify, emptying existing files when verification failed. Buffer verified content in a memory BIO and write it only on success; open the p7b path only in that same success branch. Sibling audit: both verify functions shared the same early-open pattern; sign/encrypt paths already write after success.
iliaal
force-pushed
the
fix/openssl-ss004-pre-verify-truncation
branch
from
September 10, 2026 22:12
4cf1136 to
15ae602
Compare
Owner
Author
|
Upstream: php#23651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openssl_pkcs7_verify() and openssl_cms_verify() opened their $content and $output_filename paths in write mode before verifying, emptying pre-existing files on verify failure. Dataout now buffers in an in-memory BIO during verify, success opens the destination and copies the verified bytes out, failure touches no file, and the p7bout open defers into the success branch after the signers section, creating the p7b only when the PKCS7/CMS structure will actually be written. Memory-BIO buffering stays bounded by the verified content, typically small for envelopes.