Skip to content

Add teams for O365 backup job #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ariquinones merged 1 commit into from
Aug 26, 2021
Merged

Add teams for O365 backup job #609

ariquinones merged 1 commit into from
Aug 26, 2021

Conversation

@Jchazari
Copy link
Contributor

@Jchazari Jchazari commented Aug 20, 2021

@Jchazari Jchazari marked this pull request as ready for review August 24, 2021 17:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #609 (890147f) into vbo-2.0-beta (36a9192) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           vbo-2.0-beta     #609   +/-   ##
=============================================
  Coverage         83.63%   83.64%           
=============================================
  Files               711      712    +1     
  Lines              6368     6370    +2     
  Branches            388      388           
=============================================
+ Hits               5326     5328    +2     
  Misses             1030     1030           
  Partials             12       12
Impacted Files Coverage Δ
src/sdk/model/o365/o365-job-request.ts 0.00% <ø> (ø)
src/sdk/model/o365/o365-organization.ts 100.00% <100.00%> (ø)
src/sdk/model/o365/o365-team.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8d835...890147f. Read the comment docs.

iamtash
iamtash requested changes Aug 24, 2021
View reviewed changes
Copy link
Member

@iamtash iamtash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add the type_vet field to O365JobJson and the corresponding getter to O365Job no?

@Jchazari
Copy link
Contributor Author

Jchazari commented Aug 24, 2021

need to add the type_vet field to O365JobJson and the corresponding getter to O365Job no?

Yes, will actually be adding that for Create Restore Session PR (IP-4399) since it's only really "necessary" for Restore Session / in the scope of that PR.

@iamtash
Copy link
Member

iamtash commented Aug 25, 2021

need to add the type_vet field to O365JobJson and the corresponding getter to O365Job no?

Yes, will actually be adding that for Create Restore Session PR (IP-4399) since it's only really "necessary" for Restore Session / in the scope of that PR.

got it!

@ariquinones ariquinones merged commit 6a725ed into ilanddev:vbo-2.0-beta Aug 26, 2021
@Jchazari Jchazari deleted the add-teams-for-o365-backup-job branch August 27, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamtash iamtash iamtash approved these changes

@fradinni fradinni Awaiting requested review from fradinni

@JoMas971 JoMas971 Awaiting requested review from JoMas971

@SuperConfuserUser SuperConfuserUser Awaiting requested review from SuperConfuserUser

+1 more reviewer

@ariquinones ariquinones ariquinones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jchazari @codecov-commenter @iamtash @ariquinones