Skip to content

Add teams field to O365 org & modify credentials models #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ariquinones merged 1 commit into from
Jul 29, 2021
Merged

Add teams field to O365 org & modify credentials models #601

ariquinones merged 1 commit into from
Jul 29, 2021

Conversation

@Jchazari
Copy link
Contributor

@Jchazari Jchazari commented Jul 23, 2021

@Jchazari Jchazari marked this pull request as ready for review July 26, 2021 22:30
ariquinones
ariquinones reviewed Jul 27, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #601 (12b46f6) into vbo-2.0-beta (d08fb91) will not change coverage.
The diff coverage is n/a.

❗ Current head 12b46f6 differs from pull request most recent head f5a0953. Consider uploading reports for the commit f5a0953 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           vbo-2.0-beta     #601   +/-   ##
=============================================
  Coverage         83.63%   83.63%           
=============================================
  Files               711      711           
  Lines              6368     6368           
  Branches            388      388           
=============================================
  Hits               5326     5326           
  Misses             1030     1030           
  Partials             12       12
Impacted Files Coverage Δ
.../sdk/model/o365/o365-modify-credentials-request.ts 0.00% <ø> (ø)
src/sdk/model/o365/o365-organization.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08fb91...f5a0953. Read the comment docs.

@ariquinones ariquinones merged commit c01194a into ilanddev:vbo-2.0-beta Jul 29, 2021
@Jchazari Jchazari deleted the add-teams-field-to-o365-org-and-modify-credentials branch August 5, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamtash iamtash iamtash approved these changes

@fradinni fradinni Awaiting requested review from fradinni

@JoMas971 JoMas971 Awaiting requested review from JoMas971

@SuperConfuserUser SuperConfuserUser Awaiting requested review from SuperConfuserUser

+1 more reviewer

@ariquinones ariquinones ariquinones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jchazari @codecov-commenter @ariquinones @iamtash