Skip to content

php-stem fixes search @ http://box/modules/es-wikihow #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holta merged 9 commits into from
Jul 18, 2018
Merged

php-stem fixes search @ http://box/modules/es-wikihow #925

holta merged 9 commits into from
Jul 18, 2018

Conversation

@holta
Copy link
Member

@holta holta commented Jul 18, 2018 •
edited
Loading

Fixes #829

@tim-moody @georgejhunt @jvonau please confirm what permissions the unarchive command's mode: ???? should use for these 3 files:

/etc/php/7.0/mods-available/stem.ini
/usr/lib/php/20151012/stem.so
/etc/php/7.0/apache2/conf.d/20-stem.ini

Thanks!

@holta holta added the bug label Jul 18, 2018
@holta holta added this to the 6.6 milestone Jul 18, 2018
@holta
Copy link
Member Author

holta commented Jul 18, 2018

Running this PR as is results in:

root@box:/# ls -l /etc/php/7.0/mods-available/stem.ini
-rw-r--r-- 1 root root 70 Jun 14 15:54 /etc/php/7.0/mods-available/stem.ini

root@box:/# ls -l /usr/lib/php/20151012/stem.so
-rwxr-xr-x 1 root root 649032 Jun 14 15:49 /usr/lib/php/20151012/stem.so

root@box:/# ls -l /etc/php/7.0/apache2/conf.d/20-stem.ini
lrwxrwxrwx 1 root root 36 Jun 14 15:55 /etc/php/7.0/apache2/conf.d/20-stem.ini -> /etc/php/7.0/mods-available/stem.ini

(Above is on Ubuntu 18.04, whereas Raspbian of course shows a different file size for stem.so...504604 bytes in that case.)

@holta
Copy link
Member Author

holta commented Jul 18, 2018 •
edited
Loading

Needs more functional testing but it smoke-tests cleanly (on both x86 and rpi) so I'll go ahead and merge.

Feel free to suggest post-merge improvements!

@holta holta merged commit c1807bc into iiab:master Jul 18, 2018
This was referenced Jul 19, 2018
Closed
Closed
@holta holta mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug enhancement

Projects

None yet

Milestone

6.6

Development

Successfully merging this pull request may close these issues.

1 participant

@holta