-
Notifications
You must be signed in to change notification settings - Fork 116
add WiFi not found in iiab-hotspot-on|off #4067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@avni To test this potential fix pull this PR into your install that found this issue, run |
|
@holta The order of if statements in hotspot-on|off is important the first match wins. During testing I added the network_installed clause first to ensure that worked(working in a VM). Given iiab_wireless_lan_iface detection does not rely upon iw and is generated from scraping /sys/class/net the question would become what should be the preference displayed in hotspot-on network_installed or iiab_wireless_lan_iface? I'm leaning towards having the detection displayed first. |
Sounds very reasonable. (We can always change, if absolutely necessary — e.g. if a different UI/UX proves better at some later date, for whatever reason...) |
|
Nightly Trixie on pi500
Networking disabled
Networking fully enabled wifi only |
|
@jvonau is it reasonable to go ahead with this PR now? (Any final tests you recommend if so?) |
|
It give more accurate feedback from the command line. Stepping trough network_installed, network_enabled should give the different feedback and in a VM for no wifi hardware |
|
@muthuri-dev please test this PR #4067 too if you can please! (After you're done testing...)
CLARIF: Read about the FINALLY, after the above 2, please also review (test!) this 3rd PR: |
|
I did the test on the hotspot-on|off using/on Raspberry pi 5 and after running iiab-hotspot-on wifi is again visible to other devices after running the command iiab-hotspot-on as root you need to restart raspberry pi and the command iiab-network runs ansible and then gives this results for iiab-diagnostics : https://paste.centos.org/view/3deceeb1 |
|
Given I tested the less frequent options for the revised feedback months ago, let it rip. |
|
@deldesir can you please review this after it is merged? (Thank you & we can add any revisions/suggestions of yours!) |



Fixes bug:
#4064 (comment)
Description of changes proposed in this pull request:
order of test in iiab-hotspot-on
Smoke-tested on which OS or OS's:
NA
Mention a team member @username e.g. to help with code review:
@avni @holta