Skip to content

Conversation

@jvonau
Copy link
Contributor

@jvonau jvonau commented Aug 28, 2025

Fixes bug:

#4064 (comment)

Description of changes proposed in this pull request:

order of test in iiab-hotspot-on

Smoke-tested on which OS or OS's:

NA

Mention a team member @username e.g. to help with code review:

@avni @holta

@jvonau
Copy link
Contributor Author

jvonau commented Aug 28, 2025

@avni To test this potential fix pull this PR into your install that found this issue, run sudo iiab-network then sudo iiab-hotspot-on to check the message displayed.

@holta holta added this to the 8.3 milestone Aug 28, 2025
@jvonau jvonau changed the title reverse order of detection in iiab-hostspot-on add WiFI not found in iiab-hostspot-on|off Aug 29, 2025
@jvonau jvonau changed the title add WiFI not found in iiab-hostspot-on|off add WiFi not found in iiab-hostspot-on|off Aug 29, 2025
@jvonau
Copy link
Contributor Author

jvonau commented Aug 29, 2025

@holta The order of if statements in hotspot-on|off is important the first match wins. During testing I added the network_installed clause first to ensure that worked(working in a VM). Given iiab_wireless_lan_iface detection does not rely upon iw and is generated from scraping /sys/class/net the question would become what should be the preference displayed in hotspot-on network_installed or iiab_wireless_lan_iface? I'm leaning towards having the detection displayed first.

@holta
Copy link
Member

holta commented Aug 29, 2025

what should be the preference displayed in hotspot-on network_installed or iiab_wireless_lan_iface ? I'm leaning towards having the detection displayed first.

Sounds very reasonable.

(We can always change, if absolutely necessary — e.g. if a different UI/UX proves better at some later date, for whatever reason...)

@jvonau
Copy link
Contributor Author

jvonau commented Aug 30, 2025

Nightly Trixie on pi500
Network install disabled
https://paste.centos.org/view/9d39745f

sudo iiab-hotspot-on
IIAB networking is not installed:

If you want to install it, check network_install and network_enabled in /etc/iiab/local_vars.yml and then run: sudo iiab-network

For details, see: #3302

Networking disabled
https://paste.centos.org/view/38593d76

sudo iiab-hotspot-on
IIAB networking is disabled:

If you want to enable it, check network_enabled in /etc/iiab/local_vars.yml and then run: sudo iiab-network

For details, see: #3302

Networking fully enabled wifi only
https://paste.centos.org/view/3afa8da0

@holta holta changed the title add WiFi not found in iiab-hostspot-on|off add WiFi not found in iiab-hotspot-on|off Sep 25, 2025
@holta
Copy link
Member

holta commented Sep 25, 2025

@jvonau is it reasonable to go ahead with this PR now?

(Any final tests you recommend if so?)

@jvonau
Copy link
Contributor Author

jvonau commented Sep 25, 2025

It give more accurate feedback from the command line. Stepping trough network_installed, network_enabled should give the different feedback and in a VM for no wifi hardware

@holta
Copy link
Member

holta commented Nov 1, 2025

@muthuri-dev please test this PR #4067 too if you can please! (After you're done testing...)

CLARIF: Read about the iiab-hotspot-on and iiab-hotspot-off commands here (and ask us any questions if anything's unclear, Thanks!)

FINALLY, after the above 2, please also review (test!) this 3rd PR:

@holta holta requested a review from muthuri-dev November 2, 2025 16:14
@muthuri-dev
Copy link
Member

I did the test on the hotspot-on|off using/on Raspberry pi 5
After installing the iiab and running : iiab-hotspot-on , iiab-hotspot-off and iiab-network as root user everything works fine
on iiab-hotspot-off the wifi/hotspot is not detected on the other devices
no-wifi

and after running iiab-hotspot-on wifi is again visible to other devices
wifi

after running the command iiab-hotspot-on as root you need to restart raspberry pi

iiab-hotspot-on
Created symlink '/etc/systemd/system/multi-user.target.wants/iiab-clone-wifi.service' → '/etc/systemd/system/iiab-clone-wifi.service'.
Synchronizing state of hostapd.service with SysV service script with /usr/lib/systemd/systemd-sysv-install.
Executing: /usr/lib/systemd/systemd-sysv-install enable hostapd
Created symlink '/etc/systemd/system/multi-user.target.wants/hostapd.service' → '/etc/systemd/system/hostapd.service'.
Created symlink '/etc/systemd/system/multi-user.target.wants/iiab-wifi-test.service' → '/etc/systemd/system/iiab-wifi-test.service'.

Please reboot to activate IIAB hotspot (Wi-Fi access point) via hostapd.

and the command iiab-network runs ansible and then gives this results
Snapshot_2025-11-05_18-49-27

for iiab-diagnostics : https://paste.centos.org/view/3deceeb1

@holta
Copy link
Member

holta commented Nov 5, 2025

@jvonau and @deldesir is it Okay if I merge this now?

(Yes the file diff would be easier to read if this PR was rebased 2 months later; but don't worry about that!)

@holta holta requested a review from deldesir November 5, 2025 18:59
@jvonau
Copy link
Contributor Author

jvonau commented Nov 5, 2025

Given I tested the less frequent options for the revised feedback months ago, let it rip.

@holta
Copy link
Member

holta commented Nov 5, 2025

@deldesir can you please review this after it is merged?

(Thank you & we can add any revisions/suggestions of yours!)

@holta holta merged commit bc14f94 into iiab:master Nov 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants