Skip to content

Conversation

@jvonau
Copy link
Contributor

@jvonau jvonau commented Nov 4, 2019

#2020 rebased to master

@holta holta added this to the 7.1 milestone Nov 4, 2019
@jvonau jvonau mentioned this pull request Nov 4, 2019
@holta
Copy link
Member

holta commented Nov 4, 2019

Can @jvonau's improvements of PR holta#307 + the eight 1-liner suggestions on that ticket...be added here?

@jvonau
Copy link
Contributor Author

jvonau commented Nov 4, 2019

Think I caught them when I was rebasing but poke away..

Copy link
Member

@holta holta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz remove these 2 lines, per PR holta#307 suggestions.

@holta
Copy link
Member

holta commented Nov 4, 2019

As per PR #2020 I recommend we remove or comment out https://github.com/jvonau/iiab/blob/ah_installed/runrole#L56-L77 which has a few errors in its regexp's.

IMO, the above 20+ lines should be replaced by: https://github.com/jvonau/iiab/blob/ah_installed/runrole#L25-L28

jvonau and others added 3 commits November 4, 2019 08:05
Co-Authored-By: A Holt <holta@users.noreply.github.com>
Co-Authored-By: A Holt <holta@users.noreply.github.com>
@jvonau
Copy link
Contributor Author

jvonau commented Nov 4, 2019

You are free to rebase and test #2020 but the rebase is a bit tricky.

@holta holta changed the title Ah installed ah_installed: introduce /etc/iiab/iiab_state.yml and begin breaking apart playbooks into install.yml + setup.yml + enable.yml Nov 5, 2019
@jvonau jvonau closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants