Cleanup of PR #2008 "installed": introduce /etc/iiab/iiab_state.yml and begin breaking apart playbooks into install.yml + setup.yml + enable.yml #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalite move recording to enable and fixes
sync from iiab/iiab
sync from jvonau:installed
This was referenced Oct 25, 2019
Closed
holta
changed the title
holta
changed the title
Contributor
|
close this? |
Member
Author
Ok. PR #2052 was merged to include essentially this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans @jvonau's PR #2008 for readability, maintainability & catches a few small bugs.
Implements
/etc/iiab/iiab_state.ymlinstead of config_vars2.yml per discussion during this morning's weekly IIAB call (http://minutes.iiab.io).(Arguably, this new iiab-state.yml might one day become a replacement for the archeologically-useful-and-chronological-but-very-messy-install-log
/etc/iiab/iiab.ini?)Needs code review + testing.
FYI @jvonau recommends merging (and hence incremental testing) in this order, presumably in the November timeframe, if/as each is proven: