-
Notifications
You must be signed in to change notification settings - Fork 116
Open Samba ports if enabled #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @mikerjensen as the original requester (#1664) can you please review and/test Tim's PR #1665 here? Thanks if possible! (Tagging @georgejhunt @jvonau @m-anish who might also be to help?) |
|
The proposed changes look good to me, but it's not apparent to me how to test them. |
@mikerjensen can you let us know if the following works!? PS normally you'd run the command |
|
Sorry i'm such a noob at this, i ran the below three lines from the above: and on the last line I got: Not sure what to do next. |
|
@mikerjensen ok! Let me tentatively merge this so you can test from our master branch. I can always revert it later if nec. So...please now run the following: Does that solve your Samba problem? |
|
Sorry, |
Did @mitra42 build these machines? Perhaps I wrongly assumed you were on IIAB's master branch. So just manually install the 2 necessary files: Does that solve your Samba problem? |
|
Yes, sorry, i have installed IIAB via /usr/sbin/iiab with a modified line 179: |
|
@mikerjensen can you take a quick look at PR #1677 which should make your life a great deal easier, after I hopefully merge it along with Internet Archive functionality in the coming 24h? |
|
Looking good to me! and looking forward to the IA merge...good
luck.
Mike
On 19/05/19 12:46, A Holt wrote:
@mikerjensen
can you take a quick look at PR #1677 which should make your life a
great deal easier, after I hopefully merge it along with
Internet Archive functionality in the coming 24h?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#1665?email_source=notifications\u0026email_token=ABOY56WOLZJX4FLRVJM5I63PWE4ZFA5CNFSM4HNDUBAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXANTY#issuecomment-493749967",
"url": "#1665?email_source=notifications\u0026email_token=ABOY56WOLZJX4FLRVJM5I63PWE4ZFA5CNFSM4HNDUBAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXANTY#issuecomment-493749967",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
untested