Captive Portal: works on Windows 7,8,10, with no network wire #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
georgejhunt
commented
Feb 23, 2019
georgejhunt
commented
- Tested on Windows10 internet explorer
- then downloaded chrome on windows10, and installed as default browser--worked
- Tested on Win7,8,10, with no network wire, and rpi repowered, and client caches deleted.
- retested on iphone, macbook, android 5,7 with no network wire, rpi3 repowered
- Not tested on android 8,9
- With network wire, windows10,default set to internet explorer, pasted a unsuccesful fetch of microsoft.com, on top of box.lan.home's tab, whereas when the default browser was set to edge, the captive portal worked properly --not hidden by another tab
holta
changed the title
Member
Member
|
@jvonau @tim-moody @m-anish please review if poss! |
44 tasks
Contributor
|
on windows does this favor firefox as a browser? |
Contributor
Author
|
no. Windows must have incorporated firefox code in their brownser, since
the user-agent is mozilla for IE
…On Sat, Feb 23, 2019 at 1:54 PM Tim Moody ***@***.***> wrote:
on windows does this favor firefox as a browser?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1518 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB04HNsf-aZzq859mvY_yUi6uR9dYjMIks5vQbiKgaJpZM4bOGgi>
.
|
Member
|
Are there any objections to merging this in the coming 24h? |
Member
|
FYI @jvonau believes this PR is self-contained and so safe. |
Member
@tim-moody agrees, so I'm going to go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.