dnsmasq hack (in roles/captive-portal/tasks/main.yml) so iiab-install runs on Ubuntu 16.04 #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Amazingly ./iiab-network also now seems to complete on Ubuntu 16.04 — so |
Member
Author
|
Smoke-tested on Ubuntu 16.04...other OS testing ongoing. |
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jvonau it's not just ./iiab-network, but also now "iiab-install --reinstall" that can no longer be run on Ubuntu 16.04 sadly:
Oddly while
systemctl restart dnsmasqdoesn't work... chaining togethersystemctl stop dnsmasqfollowed bysystemctl start dnsmasqdoes generally work (!)Question: is there any harm if I revise https://github.com/iiab/iiab/blob/master/roles/captive-portal/tasks/main.yml#L127-L131 to use the 2-steps above instead of the dnsmasq restart? Or is another surgical strike truly needed, e.g. from your #1311 or any other? (Not that Ubuntu 16.04 support needs to be comprehensive [it certainly doesn't!] but if Anish can still use it a tiny bit longer why not.)