Skip to content

Conversation

@jvonau
Copy link
Contributor

@jvonau jvonau commented Nov 29, 2018

Fixes Bug

Description of changes proposed in this pull request.

Smoke-tested in operating system.

Mention a team member for further information or comment using @ name

@jvonau jvonau changed the title Staging Staging of captive portal Nov 29, 2018
@jvonau
Copy link
Contributor Author

jvonau commented Nov 29, 2018

[Seeks to solve] #1306 "Failed installation on ubuntu 18.04 (mini) using IIAB 6.7 1-line installer script"

@holta holta added this to the 6.7 milestone Nov 29, 2018
@georgejhunt
Copy link
Contributor

I feel the captive portal should be it's own role, and not part of the networking role. Though I recognize that it does add some configuration to dnsmasq, and requires dnsmasq rather than bind9

@holta
Copy link
Member

holta commented Dec 3, 2018

@jvonau wrote:

If CP is to be stand-alone please clarify the use of code in iiab-gen-iptables that is part of the original PR [#1300]

( Let's try to get to the bottom of this during our Wedn call: http://minutes.iiab.io )

@holta
Copy link
Member

holta commented Dec 3, 2018

@holta
Copy link
Member

holta commented Dec 5, 2018

Discussed with @georgejhunt during today's http://minutes.iiab.io call — on hold pending @georgejhunt's review of iptables — possible this iptables rule is causing wider problems ?

@holta holta mentioned this pull request Jan 8, 2019
44 tasks
@holta holta modified the milestones: 6.7, 7.0 Jan 8, 2019
@holta holta modified the milestones: 7.0, 7.1 May 5, 2019
@jvonau jvonau closed this Jun 19, 2019
@holta holta modified the milestones: 7.1, 7.0 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants