Refining @jvonau's new fix for dhcp_service2 #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise dnsmasq will become active upon reboot because enable_services.yml would still be acting upon local_vars.yml where dnsmasq_enabled is set to True while there is not LAN interface available to bind the service to.
dhcp_service2 is used in restart.yml when not in Appliance mode
sync from iiab/iiab
sync from jvonau/iiab:dhcp2
Member
Author
|
Basic smoke testing comlpeted using |
Contributor
|
squid and friends' state are already recorded in enable_services.yml under the respective services. |
Contributor
|
Don't see the need for dhcp_service and dhcp_service2 and prefer not to overload variables. dhcp_service2 is sometimes the name of the service and sometimes a boolean. If it is a working variable lets keep it out of the whole default/local vars system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on @jvonau's PR #1202. Please see his original 2 commits and their descriptions:
bb6b3c2
9d616cf
(Needs further testing...)