Skip to content

Conversation

@holta
Copy link
Member

@holta holta commented Oct 8, 2018

Both these files need work to solve #1184 cleanly:

  • roles/network/defaults/main.yml
  • roles/network/tasks/computed_services.yml

But just for starters, this PR makes both above files more consistent with default_vars.yml and more readable.

@holta holta added this to the 6.7 milestone Oct 8, 2018
@holta
Copy link
Member Author

holta commented Oct 8, 2018

@georgejhunt can you please tell me if the following 3 lines are still needed? (Y/N)

py_captive_portal_port: "9090"
py_captive_portal_username: "Admin"
py_captive_portal_password: "changeme"

Is roles/network/defaults/main.yml the right place for them if they're still needed? (@tim-moody suggests this is not the right place for py_captive_portal_* variables?)

@holta
Copy link
Member Author

holta commented Oct 8, 2018

@jvonau to solve the Ubuntu 18.04 problem arising from iiab_network_mode: Appliance are you recommending fallback value dhcpd_service2: disabled be initialized around line 72 of https://github.com/iiab/iiab/blob/master/roles/network/defaults/main.yml#L72 ?

@holta
Copy link
Member Author

holta commented Oct 8, 2018

Smoke-tested on Ubuntu 18.04

Let's refine further...e.g. during our Tuesday 10AM NYC Time community/team call (http://minutes.iiab.io)

@holta holta mentioned this pull request Oct 8, 2018
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant