-
Notifications
You must be signed in to change notification settings - Fork 116
Beginnings of Captive Portal / dnsmasq cleanup, towards solving #1184 #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@georgejhunt can you please tell me if the following 3 lines are still needed? (Y/N) Is roles/network/defaults/main.yml the right place for them if they're still needed? (@tim-moody suggests this is not the right place for py_captive_portal_* variables?) |
|
@jvonau to solve the Ubuntu 18.04 problem arising from |
|
Smoke-tested on Ubuntu 18.04 Let's refine further...e.g. during our Tuesday 10AM NYC Time community/team call (http://minutes.iiab.io) |
Both these files need work to solve #1184 cleanly:
But just for starters, this PR makes both above files more consistent with default_vars.yml and more readable.