Skip to content

3.2.8, Build dlls in GitHub actions #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TysonAndre merged 1 commit into from
Oct 17, 2022
Merged

3.2.8, Build dlls in GitHub actions #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ environment:
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
ARCH: x86
VC: vs16
PHP_VER: 8.2.0RC3
PHP_VER: 8.2.0RC4
TS: 1
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
ARCH: x64
VC: vs16
PHP_VER: 8.2.0RC3
PHP_VER: 8.2.0RC4
TS: 0
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
ARCH: x86
Expand Down
62 changes: 62 additions & 0 deletions .github/workflows/build_dlls.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: Build DLLs
# Based on https://github.com/TysonAndre/var_representation/blob/main/.github/workflows/build_dlls.yml
# which is based on https://github.com/krakjoe/apcu/blob/migbinaryer/.github/workflows/config.yml
# Builds DLLs for 64-bit php.
# See https://windows.php.net/ - At this time, the windows PHP team no longer has access to the machine used to build dlls.

on:
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
release:
types: [published]

jobs:
windows:
defaults:
run:
shell: cmd
strategy:
matrix:
version: ["7.2", "7.3", "7.4", "8.0", "8.1", "8.2"]
arch: [x64]
ts: [nts, ts]
runs-on: windows-latest
steps:
- name: Checkout igbinary
uses: actions/checkout@v2
- name: Setup PHP
id: setup-php
uses: cmb69/setup-php-sdk@v0.6
with:
version: ${{matrix.version}}
arch: ${{matrix.arch}}
ts: ${{matrix.ts}}
- name: Enable Developer Command Prompt
uses: ilammy/msvc-dev-cmd@v1
with:
arch: ${{matrix.arch}}
toolset: ${{steps.setup-php.outputs.toolset}}
- name: phpize
run: phpize
- name: configure
run: configure --enable-igbinary --enable-debug-pack --with-prefix=${{steps.setup-php.outputs.prefix}}
- name: make
run: nmake
# Run tests, failing if they fail. REPORT_EXIT_STATUS=1 is the default for tests in php 7.2+
- name: test
run: nmake test TESTS="--show-diff tests"
- name: package
run: |
md .install
copy LICENSE README.md .install
if exist x64 (
if exist x64\Release (set prefix=x64\Release) else set prefix=x64\Release_TS
) else (
if exist Release (set prefix=Release) else set prefix=Release_TS
)
copy %prefix%\php_igbinary.dll .install
copy %prefix%\php_igbinary.pdb .install
- name: Upload artifacts
uses: actions/upload-artifact@v3.1.0
with:
name: igbinary-${{github.ref}}-Windows-php-${{matrix.version}}-${{matrix.arch}}-${{matrix.ts}}
path: .install
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
DOCKER_ARCHITECTURE: i386
- PHP_VERSION: '8.1'
PHP_VERSION_FULL: 8.1.11
- PHP_VERSION: '8.2.0RC3'
- PHP_VERSION: '8.2.0RC4'
PHP_VERSION_FULL: 8.2.0RC4
- PHP_VERSION: '8.2.0RC3'
- PHP_VERSION: '8.2.0RC4'
PHP_VERSION_FULL: 8.2.0RC4
DOCKER_ARCHITECTURE: i386

Expand Down
3 changes: 2 additions & 1 deletion NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
3.2.8dev 2022-??-??
3.2.8 2022-10-16
=======

* Reduce excessive inlining to reduce shared library size.
* Miscellaneous optimizations.
* Set up CI job to build dlls on https://github.com/igbinary/igbinary - at the moment, the infrastructure used by the Windows for php team has been broken for months.

3.2.7 2022-01-12
=======
Expand Down
5 changes: 3 additions & 2 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ memcached or similar memory based storages for serialized data.</description>
<email>tandre@php.net</email>
<active>yes</active>
</lead>
<date>2022-01-12</date>
<date>2022-10-16</date>
<time>16:00:00</time>
<version>
<release>3.2.8dev</release>
<release>3.2.8</release>
<api>1.3.1</api>
</version>
<stability>
Expand All @@ -50,6 +50,7 @@ memcached or similar memory based storages for serialized data.</description>
(especially PHP 8.2 `readonly` classes)
* Emit a deprecation notice when igbinary_unserialize() adds dynamic properties to a class without `#[AllowDynamicProperties]` in PHP 8.2.
Doing that would become an Error in PHP 9.0.
* Set up CI job to build dlls on https://github.com/igbinary/igbinary - at the moment, the infrastructure used by the Windows for php team has been broken for months.
</notes>
<contents>
<dir name="/">
Expand Down
2 changes: 1 addition & 1 deletion src/php7/igbinary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ struct zval;
/** Binary protocol version of igbinary. */
#define IGBINARY_FORMAT_VERSION 0x00000002

#define PHP_IGBINARY_VERSION "3.2.8dev"
#define PHP_IGBINARY_VERSION "3.2.8"

/* Macros */

Expand Down