Fix lint errors #50
Merged
Fix lint errors #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpicker and fix a a11y warning.
…tualized to capture event on ro
Codecov Report
@@ Coverage Diff @@
## dep-bump #50 +/- ##
===========================================
+ Coverage 0.02% 0.02% +<.01%
===========================================
Files 285 284 -1
Lines 8333 8255 -78
===========================================
Hits 2 2
+ Misses 8331 8253 -78
Continue to review full report at Codecov.
|
evansiroky
reviewed
Mar 8, 2017
| }}> | ||
| <h3 | ||
| onClick={this._toggleExpanded} | ||
| onKeyDown={(e) => { |
Contributor
There was a problem hiding this comment.
Seems like this keyDown handler is implemented the same way in a lot of places. We should make a helper for the default action.
Contributor
There was a problem hiding this comment.
Yea, maybe a higher order component for accessible interactions?
Contributor
Author
There was a problem hiding this comment.
I would say create a ticket and we should consider that in the future but leave it out for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.