Build with Vite #1045
Open
Build with Vite #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (graphHopperResponseFile) { | ||
| nock('https://graphhopper.com') | ||
| // Turn on log in order to view nock request URLs. | ||
| .log(console.log) |
Contributor
Author
There was a problem hiding this comment.
nock.log no longer exists in recent node versions.
| "mastarm": "^5.3.1", | ||
| "md5-file": "^4.0.0", | ||
| "nock": "^9.0.14", | ||
| "nock": "^13.5.6", |
Contributor
Author
There was a problem hiding this comment.
Nock 14+ require adding other mocks that are currently missing. Lmk is that's worth it in this PR.
This reverts commit eea1536.
Contributor
Author
|
Build passes!! 🎉🎉🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR replaces mastarm with Vite as the build system (for dev and production). Other parts involving mastarm remain unchanged.
mastarm buildormastarm deployUseful commands:
env YAML_CONFIG=<path-to-frontend>/env.yml yarn startenv YAML_CONFIG=<path-to-frontend>/env.yml yarn build